Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: pkg/analysis_server/test/analysis/get_errors_test.dart

Issue 486003003: Start using code-generated protocol classes in analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/analysis/get_errors_test.dart
diff --git a/pkg/analysis_server/test/analysis/get_errors_test.dart b/pkg/analysis_server/test/analysis/get_errors_test.dart
index 268774e18946668143f349aeaae081f96be9cf64..cf4a7ed85eeb7df6f8cfa97f20280ead6f68e066 100644
--- a/pkg/analysis_server/test/analysis/get_errors_test.dart
+++ b/pkg/analysis_server/test/analysis/get_errors_test.dart
@@ -6,10 +6,10 @@ library test.analysis.get_errors;
import 'dart:async';
-import 'package:analysis_server/src/computer/error.dart';
import 'package:analysis_server/src/constants.dart';
import 'package:analysis_server/src/domain_analysis.dart';
import 'package:analysis_server/src/protocol.dart';
+import 'package:analysis_server/src/protocol2.dart';
import 'package:analysis_testing/reflective_tests.dart';
import 'package:analyzer/file_system/file_system.dart';
import 'package:unittest/unittest.dart';
@@ -76,8 +76,8 @@ main() {
expect(errors, hasLength(1));
{
AnalysisError error = errors[0];
- expect(error.severity, 'ERROR');
- expect(error.type, 'SYNTACTIC_ERROR');
+ expect(error.severity, ErrorSeverity.ERROR);
+ expect(error.type, ErrorType.SYNTACTIC_ERROR);
expect(error.location.file, testFile);
expect(error.location.startLine, 2);
}
@@ -127,8 +127,7 @@ main() {
Future<List<AnalysisError>> _getErrors(String file) {
Request request = _createGetErrorsRequest();
return serverChannel.sendRequest(request).then((Response response) {
- List errorsJsons = response.getResult(ERRORS);
- return errorsJsons.map(AnalysisError.fromJson).toList();
+ return new AnalysisGetErrorsResult.fromResponse(response).errors;
});
}
}
« no previous file with comments | « pkg/analysis_server/lib/src/protocol.dart ('k') | pkg/analysis_server/test/analysis/notification_errors_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698