Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 485953003: Make Fullscreen::fullyExitFullscreen() static (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
falken, tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Project:
blink
Visibility:
Public.

Description

Make Fullscreen::fullyExitFullscreen() static The implementation may not need the Fullscreen instance for the Document fullyExitFullscreen() is given, and can avoid creating one for the top-level Document in case there is no fullscreen element, which is >99% of time. BUG=403763 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180563

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M Source/core/dom/Fullscreen.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Fullscreen.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/FullscreenController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDocument.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
PTAL and CQ if no nits.
6 years, 4 months ago (2014-08-19 12:33:41 UTC) #1
philipj_slow
I plan to eventually make requestFullscreen() and exitFullscreen() static as well, since after a spec ...
6 years, 4 months ago (2014-08-19 12:36:28 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-19 14:55:01 UTC) #3
tkent
lgtm
6 years, 4 months ago (2014-08-19 14:55:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/485953003/1
6 years, 4 months ago (2014-08-19 14:56:44 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 15:32:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 180563

Powered by Google App Engine
This is Rietveld 408576698