scripts/slave/recipe_modules/filter/example.expected/bad_retcode_doesnt_fail.json - Issue 485873004: Adds ability for builders to only compile targets affected by change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/filter/example.expected/bad_retcode_doesnt_fail.json

Issue 485873004: Adds ability for builders to only compile targets affected by change (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: merge 2 trunk Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/filter/example.expected/analyzes_returns_true.json ('k') | scripts/slave/recipe_modules/filter/example.expected/basic.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/filter/example.expected/bad_retcode_doesnt_fail.json

diff --git a/scripts/slave/recipe_modules/filter/example.expected/bad_retcode_doesnt_fail.json b/scripts/slave/recipe_modules/filter/example.expected/bad_retcode_doesnt_fail.json

index abd4851a4b440e6266a7182962e2b17ab4299703..35ba3d4c76793d80decd9213d14f080d0710e34d 100644

--- a/scripts/slave/recipe_modules/filter/example.expected/bad_retcode_doesnt_fail.json

+++ b/scripts/slave/recipe_modules/filter/example.expected/bad_retcode_doesnt_fail.json

@@ -16,7 +16,7 @@

"-u",

"[SLAVE_BUILD]/build/gyp_chromium",

"--analyzer",

- "{\"files\": [\"foo.cc\"], \"targets\": null}",

+ "{\"files\": [\"foo.cc\"], \"targets\": []}",

"/path/to/tmp/json"

"env": {

@@ -26,6 +26,7 @@

"~followup_annotations": [

"step returned non-zero exit code: -1",

"@@@STEP_LOG_LINE@json.output@{@@@",

+ "@@@STEP_LOG_LINE@json.output@ \"build_targets\": [], @@@",

"@@@STEP_LOG_LINE@json.output@ \"status\": \"No dependency\", @@@",

"@@@STEP_LOG_LINE@json.output@ \"targets\": []@@@",

"@@@STEP_LOG_LINE@json.output@}@@@",