scripts/slave/recipe_modules/filter/example.expected/basic.json - Issue 485873004: Adds ability for builders to only compile targets affected by change

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipe_modules/filter/example.expected/basic.json

Issue 485873004: Adds ability for builders to only compile targets affected by change (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: merge 2 trunk Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipe_modules/filter/example.expected/bad_retcode_doesnt_fail.json ('k') | scripts/slave/recipe_modules/filter/example.expected/doesnt_match_exclusion.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "git",	4 "git",

5 "diff",	5 "diff",

6 "--cached",	6 "--cached",

7 "--name-only"	7 "--name-only"

8 ],	8 ],

9 "cwd": "[SLAVE_BUILD]",	9 "cwd": "[SLAVE_BUILD]",

10 "name": "git diff to analyze patch",	10 "name": "git diff to analyze patch",

11 "stdout": "/path/to/tmp/"	11 "stdout": "/path/to/tmp/"

12 },	12 },

13 {	13 {

14 "cmd": [	14 "cmd": [

15 "python",	15 "python",

16 "-u",	16 "-u",

17 "[SLAVE_BUILD]/build/gyp_chromium",	17 "[SLAVE_BUILD]/build/gyp_chromium",

18 "--analyzer",	18 "--analyzer",

19 "{\"files\": [\"yy\"], \"targets\": []}",	19 "{\"files\": [\"yy\"], \"targets\": []}",

20 "/path/to/tmp/json"	20 "/path/to/tmp/json"

21 ],	21 ],

22 "env": {	22 "env": {

23 "GYP_DEFINES": "component=static_library gomadir='[BUILD]/goma' target_arc h=x64 use_goma=1"	23 "GYP_DEFINES": "component=static_library gomadir='[BUILD]/goma' target_arc h=x64 use_goma=1"

24 },	24 },

25 "name": "analyze",	25 "name": "analyze",

26 "~followup_annotations": [	26 "~followup_annotations": [

27 "@@@STEP_TEXT@No compile necessary@@@",	27 "@@@STEP_TEXT@No compile necessary@@@",

28 "@@@STEP_LOG_LINE@json.output@{@@@",	28 "@@@STEP_LOG_LINE@json.output@{@@@",

	29 "@@@STEP_LOG_LINE@json.output@ \"build_targets\": [], @@@",

29 "@@@STEP_LOG_LINE@json.output@ \"status\": \"No dependency\", @@@",	30 "@@@STEP_LOG_LINE@json.output@ \"status\": \"No dependency\", @@@",

30 "@@@STEP_LOG_LINE@json.output@ \"targets\": []@@@",	31 "@@@STEP_LOG_LINE@json.output@ \"targets\": []@@@",

31 "@@@STEP_LOG_LINE@json.output@}@@@",	32 "@@@STEP_LOG_LINE@json.output@}@@@",

32 "@@@STEP_LOG_END@json.output@@@"	33 "@@@STEP_LOG_END@json.output@@@"

33 ]	34 ]

34 },	35 },

35 {	36 {

36 "cmd": [	37 "cmd": [

37 "echo",	38 "echo",

38 "Why hello, there."	39 "Why hello, there."

39 ],	40 ],

40 "name": "hello"	41 "name": "hello"

41 }	42 }

42 ]	43 ]

OLD	NEW