Adds ability for builders to only compile targets affected by change

scripts/slave/recipe_modules/filter/example.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 DEPS = [
   'chromium',
   'filter',
   'json',
   'path',
   'properties',
   'raw_io',
   'step',
 ]
 
 def GenSteps(api):
   api.path['checkout'] = api.path['slave_build']
   api.chromium.set_config('chromium')
   api.filter.does_patch_require_compile()
   assert (api.filter.result and api.properties['example_result']) or \
       (not api.filter.result and not api.properties['example_result'])
   assert (not api.properties['example_matching_exes'] or
           list(api.properties['example_matching_exes']) ==
           api.filter.matching_exes)
+  assert (not api.properties['example_matching_compile_targets'] or
+          list(api.properties['example_matching_compile_targets']) ==
+          api.filter.compile_targets)

[iannucci, 2014/08/20 17:54:39]

nit: these asserts seem overly verbose... couldn't you just do

assert api.properties.get(..., []) == api.filter....

and then omit the properties in the test cases? If the properties are omitted
(as opposed to set-to-None), then get will return the default on the right hand
side.

[sky, 2014/08/20 20:26:33]

I only wanted to do the interesting part of the assert (the part after the or)
if the property was actually provided. But I had this a bit wrong as both [] and
None are the same. Updated.

   api.step('hello', ['echo', 'Why hello, there.'])
 
 def GenTests(api):
   # Trivial test with no exclusions and nothing matching.
   yield (api.test('basic') +
          api.properties(filter_exclusions=[]) +
          api.properties(example_result=None) +
          api.properties(example_matching_exes=None) +
+         api.properties(example_matching_compile_targets=None) +

[iannucci, 2014/08/20 17:54:39]

fyi: you can do multiple properties per call here:

api.properties(
  key=value,
  other=value,
  ...
)

[sky, 2014/08/20 20:26:32]

Done.

          api.override_step_data(
           'git diff to analyze patch',
           api.raw_io.stream_output('yy')))
   
   # Matches exclusions
   yield (api.test('match_exclusion') +
          api.properties(filter_exclusions=['fo.*']) +
          api.properties(example_result=1) +
          api.properties(example_matching_exes=None) +
+         api.properties(example_matching_compile_targets=None) +
          api.override_step_data(
           'git diff to analyze patch',
           api.raw_io.stream_output('foo.cc')))
 
   # Doesnt match exclusion.
   yield (api.test('doesnt_match_exclusion') +
          api.properties(filter_exclusions=['fo.*']) +
          api.properties(example_result=None) +
          api.properties(example_matching_exes=None) +
+         api.properties(example_matching_compile_targets=None) +
          api.override_step_data(
           'git diff to analyze patch',
           api.raw_io.stream_output('bar.cc')))
 
   # Analyze returns matching result.
   yield (api.test('analyzes_returns_true') +
          api.properties(example_result=1) +
          api.properties(example_matching_exes=None) +
+         api.properties(example_matching_compile_targets=None) +
          api.override_step_data(
           'analyze',
           api.json.output({'status': 'Found dependency',
-                                  'targets': []})))
+                           'targets': [],
+                           'build_targets': []})))
 
   # Analyze returns matching tests while matching all.
   yield (api.test('analyzes_matches_all_exes') +
-         api.properties(matching_exes=['foo', 'bar']) +
-         api.properties(example_matching_exes=['foo']) +
          api.properties(example_result=1) +
+         api.properties(example_matching_exes=None) +
+         api.properties(example_matching_compile_targets=None) +
          api.override_step_data(
           'analyze',
-          api.json.output({'status': 'Found dependency (all)',
-                                  'targets': ['foo']})))
+          api.json.output({'status': 'Found dependency (all)'})))
 
   # Analyze matches all and returns matching tests.
   yield (api.test('analyzes_matches_exes') +
          api.properties(matching_exes=['foo', 'bar']) +
          api.properties(example_matching_exes=['foo']) +
+         api.properties(example_matching_compile_targets=None) +
          api.properties(example_result=1) +
          api.override_step_data(
           'analyze',
           api.json.output({'status': 'Found dependency',
-                                  'targets': ['foo']})))
+                           'targets': ['foo'],
+                           'build_targets': []})))
+
+  # Analyze matches all and returns matching tests.
+  yield (api.test('analyzes_matches_compile_targets') +
+         api.properties(example_matching_exes=None) +
+         api.properties(example_matching_compile_targets=['bar']) +
+         api.properties(example_result=1) +
+         api.override_step_data(
+          'analyze',
+          api.json.output({'status': 'Found dependency',
+                           'targets': ['foo'],
+                           'build_targets': ['bar']})))
 
   # Analyze with error condition.
   yield (api.test('analyzes_error') +
          api.properties(matching_exes=None) +
          api.properties(example_matching_exes=None) +
+         api.properties(example_matching_compile_targets=None) +
          api.properties(example_result=1) +
          api.override_step_data(
           'analyze',
           api.json.output({'error': 'ERROR'})))
 
   # Analyze with python returning bad status.
   yield (api.test('bad_retcode_doesnt_fail') +
          api.properties(matching_exes=None) +
          api.properties(example_matching_exes=None) +
+         api.properties(example_matching_compile_targets=None) +
          api.properties(example_result=1) +
          api.step_data(
           'analyze',
           retcode=-1))