Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 485833003: Pull new GN, update toolchain definitions (Closed)

Created:
6 years, 4 months ago by brettw
Modified:
6 years, 4 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Pull new GN, update toolchain definitions This pulls buildtools to get GN 290714 and updates to the new style of toolchain definitions in that revision. Unfortunately, this new version doesn't support getting the outputs of excutables, which made the android unit test template a bit less automatic. We can consider how to best fix this in the future. R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290894

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : mac #

Patch Set 7 : #

Patch Set 8 : buildtools #

Patch Set 9 : Use the right sha1 #

Patch Set 10 : Add asm tool #

Patch Set 11 : Fix Android #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -210 lines) Patch
M DEPS View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/rules.gni View 1 2 3 4 5 6 7 3 chunks +16 lines, -1 line 0 comments Download
M build/toolchain/android/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 1 chunk +9 lines, -2 lines 0 comments Download
M build/toolchain/gcc_toolchain.gni View 1 2 3 4 5 6 7 8 9 1 chunk +85 lines, -35 lines 2 comments Download
M build/toolchain/mac/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +107 lines, -43 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 1 2 3 4 5 6 1 chunk +139 lines, -128 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
6 years, 4 months ago (2014-08-20 00:42:10 UTC) #1
jamesr
ERROR at //build/toolchain/gcc_toolchain.gni:88:9: Assignment had no effect. "{{source_out_dir}}/{{target_output_name}}.{{source_name_part}}.o", ^------------------------------------------------------------------ You set the variable "outputs" here ...
6 years, 4 months ago (2014-08-20 00:48:29 UTC) #2
brettw
On 2014/08/20 00:48:29, jamesr wrote: > ERROR at //build/toolchain/gcc_toolchain.gni:88:9: Assignment had no effect. > "{{source_out_dir}}/{{target_output_name}}.{{source_name_part}}.o", ...
6 years, 4 months ago (2014-08-20 04:46:03 UTC) #3
brettw
On 2014/08/20 00:48:29, jamesr wrote: > ERROR at //build/toolchain/gcc_toolchain.gni:88:9: Assignment had no effect. > "{{source_out_dir}}/{{target_output_name}}.{{source_name_part}}.o", ...
6 years, 4 months ago (2014-08-20 04:46:04 UTC) #4
jamesr
lgtm https://codereview.chromium.org/485833003/diff/200001/build/toolchain/gcc_toolchain.gni File build/toolchain/gcc_toolchain.gni (right): https://codereview.chromium.org/485833003/diff/200001/build/toolchain/gcc_toolchain.gni#newcode129 build/toolchain/gcc_toolchain.gni:129: # These variables are not build into GN ...
6 years, 4 months ago (2014-08-20 19:38:27 UTC) #5
brettw
6 years, 4 months ago (2014-08-20 19:39:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #11 manually as 290894 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698