Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 485833002: HTTP2 draft 14 support (Closed)

Created:
6 years, 4 months ago by Bence
Modified:
6 years, 4 months ago
Reviewers:
Johnny
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

HTTP2 draft 14 support This master CL lands recent SPDY changes through 73573949, extending them with Chromium-specific updates to constants and enums, protocol negotiation tokens, and tests. This CL is intended to be commited but not reviewed, and is the union of the following changes, which in turn are intended to be reviewed but not commited. (Most recent on top, oldest on bottom.) Fix bug in HTTP/2 frame size limits. This lands server change 73573949. https://crrev.com/478903004 Update npn/alpn tokens to HTTP2-draft14. https://crrev.com/486493003 Add kSpdyMaxControlFrameSize and kControlFrameSizeLimit constants. This lands server change 73427537. https://crrev.com/486873002 Add TODO. This lands server change 73426819. https://crrev.com/479313002 Add an extra byte to the length field for HTTP/2 frame headers. This lands server change 73424406. https://crrev.com/479303002 Change order of tests. https://crrev.com/483863002 Remove reference set and exchange header and static table in HPACK. This lands server change 73299534. https://crrev.com/480573003 Add new settings to SPDY4 for h2-14. This lands server change 72726557. https://crrev.com/480183002 Add kHttp2VersionString. This lands server change 72173526. https://crrev.com/485813002 HTTP2 draft 13: support unknown frame types and settings types as extensions. This lands server change 70895882. https://crrev.com/483843004 Allow unrecognized error codes as part of HTTP/2 extensions. This lands server change 70873693. https://crrev.com/475043002 BUG=400336 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291161

Patch Set 1 #

Patch Set 2 : Add mock OnUnknownFrame to SpdyFramerVisitor in spdy_interface_test. #

Patch Set 3 : Add kHttp2VersionString. #

Patch Set 4 : Add new settings to SPDY4 for h2-14. #

Patch Set 5 : Remove reference set and exchange header and static table in HPACK. #

Patch Set 6 : Change order of tests. #

Patch Set 7 : Add an extra byte to the length field for HTTP/2 frame headers. #

Patch Set 8 : Add TODO. #

Patch Set 9 : Add kSpdyMaxControlFrameSize and kControlFrameSizeLimit constants. #

Patch Set 10 : Update npn/alpn tokens to HTTP2-draft14. #

Patch Set 11 : Fix bug in HTTP/2 frame size limits. #

Patch Set 12 : Add ignore_result(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+923 lines, -974 lines) Patch
M net/data/spdy_tests/examples_07.hpack View 1 2 3 4 Binary file 0 comments Download
M net/http/http_response_info.cc View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_server_properties.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_headers_stream.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/ssl_client_socket.cc View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -4 lines 0 comments Download
M net/spdy/buffered_spdy_framer.h View 3 chunks +8 lines, -1 line 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/spdy/buffered_spdy_framer_unittest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M net/spdy/fuzzing/hpack_fuzz_util_test.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/hpack_constants.h View 1 2 3 4 1 chunk +3 lines, -11 lines 0 comments Download
M net/spdy/hpack_decoder.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_decoder.cc View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +21 lines, -66 lines 0 comments Download
M net/spdy/hpack_decoder_test.cc View 1 2 3 4 24 chunks +151 lines, -165 lines 0 comments Download
M net/spdy/hpack_encoder.h View 1 2 3 4 2 chunks +1 line, -9 lines 0 comments Download
M net/spdy/hpack_encoder.cc View 1 2 3 4 4 chunks +21 lines, -141 lines 0 comments Download
M net/spdy/hpack_encoder_test.cc View 1 2 3 4 9 chunks +22 lines, -82 lines 0 comments Download
M net/spdy/hpack_entry.h View 1 2 3 4 3 chunks +2 lines, -8 lines 0 comments Download
M net/spdy/hpack_entry.cc View 1 2 3 4 3 chunks +1 line, -5 lines 0 comments Download
M net/spdy/hpack_entry_test.cc View 1 2 3 4 4 chunks +0 lines, -4 lines 0 comments Download
M net/spdy/hpack_header_table.h View 1 2 3 4 4 chunks +1 line, -17 lines 0 comments Download
M net/spdy/hpack_header_table.cc View 1 2 3 4 5 chunks +6 lines, -35 lines 0 comments Download
M net/spdy/hpack_header_table_test.cc View 1 2 3 4 8 chunks +26 lines, -64 lines 0 comments Download
M net/spdy/mock_spdy_framer_visitor.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_frame_builder.h View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M net/spdy/spdy_frame_builder.cc View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M net/spdy/spdy_framer.h View 1 chunk +7 lines, -1 line 0 comments Download
M net/spdy/spdy_framer.cc View 1 2 3 4 5 6 7 12 chunks +51 lines, -29 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 1 2 3 4 5 6 7 8 9 10 73 chunks +460 lines, -302 lines 0 comments Download
M net/spdy/spdy_protocol.h View 1 2 3 4 5 6 7 8 9 10 5 chunks +16 lines, -3 lines 0 comments Download
M net/spdy/spdy_protocol.cc View 1 2 3 4 5 6 7 8 9 10 8 chunks +38 lines, -10 lines 0 comments Download
M net/spdy/spdy_session.h View 2 chunks +2 lines, -0 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/spdy/spdy_test_utils.cc View 1 2 3 4 5 6 2 chunks +4 lines, -6 lines 0 comments Download
M net/tools/flip_server/spdy_interface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/flip_server/spdy_interface.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/tools/flip_server/spdy_interface_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Johnny
lgtm, as I have reviewed all included CL's.
6 years, 4 months ago (2014-08-21 18:51:14 UTC) #1
Bence
The CQ bit was checked by bnc@chromium.org
6 years, 4 months ago (2014-08-21 19:03:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bnc@chromium.org/485833002/450001
6 years, 4 months ago (2014-08-21 19:06:12 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 20:17:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #12 (450001) as 291161

Powered by Google App Engine
This is Rietveld 408576698