Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 485793003: Removing OptInStateFilter settings, which are only for authenticated users. (Closed)

Created:
6 years, 4 months ago by Charlie
Modified:
6 years, 4 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, rkc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removing OptInStateFilter settings, which are only for authenticated users. Reverses most of the changes in https://codereview.chromium.org/459903006/. BUG=404820 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290429

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -68 lines) Patch
M components/copresence/rpc/rpc_handler.cc View 2 chunks +0 lines, -35 lines 0 comments Download
M components/copresence/rpc/rpc_handler_unittest.cc View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Charlie
6 years, 4 months ago (2014-08-18 22:01:12 UTC) #1
xiyuan
lgtm
6 years, 4 months ago (2014-08-18 22:04:22 UTC) #2
Charlie
The CQ bit was checked by ckehoe@chromium.org
6 years, 4 months ago (2014-08-18 22:15:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckehoe@chromium.org/485793003/1
6 years, 4 months ago (2014-08-18 22:17:33 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-18 23:44:50 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 00:33:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 290429

Powered by Google App Engine
This is Rietveld 408576698