Issue 485783002: Don't pass -target arm-linux-gnueabihf on android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 485783002: Don't pass -target arm-linux-gnueabihf on android. (Closed)

Created:
6 years, 4 months ago by Nico

Modified:
6 years, 4 months ago

Reviewers:
Sam Clegg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Don't pass -target arm-linux-gnueabihf on android. Fixes a regression from r395832. (This isn't a visible change as the android build happens to pass -target arm-linux-androideabi later on the compile line, but relying on this is risky.) BUG=395832 TBR=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290308

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	build/common.gypi	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Nico

6 years, 4 months ago (2014-08-18 18:21:34 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as 290308 (presubmit successful).