tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py - Issue 485743002: Add support for codepen to form_based_credentials_background

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py

Issue 485743002: Add support for codepen to form_based_credentials_background (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: WIP Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/backends/form_based_credentials_backend.py ('K') | « tools/telemetry/telemetry/core/backends/form_based_credentials_backend.py ('k') | tools/telemetry/telemetry/core/backends/google_credentials_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py

diff --git a/tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py b/tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py

index 3ce0c864aa0cb371ff22b8cdf9839dc948daeeae..866b240c8dfe9acfdf7ca90abeb24c6177f51fff 100644

--- a/tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py

+++ b/tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py

@@ -97,6 +97,7 @@ class FormBasedCredentialsBackendUnitTestBase(unittest.TestCase):

def _LoginUsingMock(self, backend, login_page_url, email_element_id,

password_element_id): # pylint: disable=R0201

tab = simple_mock.MockObject()

+ ar = simple_mock.MockObject()

config = {'username': 'blah',

'password': 'blargh'}

@@ -106,6 +107,8 @@ class FormBasedCredentialsBackendUnitTestBase(unittest.TestCase):

tab.ExpectCall('EvaluateJavaScript', _).WillReturn(True)

tab.ExpectCall('EvaluateJavaScript', _).WillReturn(False)

tab.ExpectCall('WaitForDocumentReadyStateToBeInteractiveOrBetter')

+ ar.ExpectCall('WaitForJavaScriptExpression')

+ ar.ExpectCall('WaitForJavaScriptCondition')

def VerifyEmail(js):

assert email_element_id in js

@@ -124,4 +127,4 @@ class FormBasedCredentialsBackendUnitTestBase(unittest.TestCase):

# Checking for form still up.

tab.ExpectCall('EvaluateJavaScript', _).WillReturn(False)

- backend.LoginNeeded(tab, config)

+ backend.LoginNeeded(tab, ar, config)