Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: tools/telemetry/telemetry/core/backends/codepen_credentials_backend.py

Issue 485743002: Add support for codepen to form_based_credentials_background (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Undo tracing timeout change Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/codepen_credentials_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/facebook_credentials_backend.py b/tools/telemetry/telemetry/core/backends/codepen_credentials_backend.py
similarity index 54%
copy from tools/telemetry/telemetry/core/backends/facebook_credentials_backend.py
copy to tools/telemetry/telemetry/core/backends/codepen_credentials_backend.py
index 2b66f9dc1063fbd96616f4d00da097672ebdccc7..5aed5d6befd688e716b83c9b7f7c228f0dd5d39e 100644
--- a/tools/telemetry/telemetry/core/backends/facebook_credentials_backend.py
+++ b/tools/telemetry/telemetry/core/backends/codepen_credentials_backend.py
@@ -1,33 +1,37 @@
-# Copyright 2013 The Chromium Authors. All rights reserved.
+# Copyright 2014 The Chromium Authors. All rights reserved.
tonyg 2014/08/20 17:37:17 Let's split the tools/telemetry/* changes into a n
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
from telemetry.core.backends import form_based_credentials_backend
-class FacebookCredentialsBackend(
+class CodePenCredentialsBackend(
form_based_credentials_backend.FormBasedCredentialsBackend):
def IsAlreadyLoggedIn(self, tab):
+ # Redirects to sign up page for logged in users.
return tab.EvaluateJavaScript(
- 'document.getElementById("fbNotificationsList")!== null || '
- 'document.getElementById("m_home_notice")!== null')
+ 'document.querySelector(".login-area")===null')
@property
def credentials_type(self):
tonyg 2014/08/20 17:37:17 Not for this CL, but just thinking aloud that it w
- return 'facebook'
+ return 'codepen'
@property
def url(self):
- return 'http://www.facebook.com/'
+ return 'https://codepen.io/login'
@property
def login_form_id(self):
- return 'login_form'
+ return 'login-login-form'
+
+ @property
+ def login_button_id(self):
+ return 'log-in-button'
@property
def login_input_id(self):
- return 'email'
+ return 'login-email-field'
@property
def password_input_id(self):
- return 'pass'
+ return 'login-password-field_'

Powered by Google App Engine
This is Rietveld 408576698