Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 485733002: Will no longer force jobs=1 with filters in bot mode. (Closed)

Created:
6 years, 4 months ago by phoglund_chromium
Modified:
6 years, 4 months ago
Reviewers:
jam, Paweł Hajdan Jr.
CC:
chromium-reviews, erikwright+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Will no longer force jobs=1 with filters in bot mode. The WebRTC bots happen to run with gtest filters, but want to run tests in parallel anyway. It makes sense for bot mode to disregard the gtest filter rule, which is a good heuristic in other cases. BUG=402089 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290274

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M base/test/launcher/test_launcher.cc View 3 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
phoglund_chromium
6 years, 4 months ago (2014-08-18 15:31:57 UTC) #1
Paweł Hajdan Jr.
LGTM + John FYI
6 years, 4 months ago (2014-08-18 15:36:17 UTC) #2
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 4 months ago (2014-08-18 15:42:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/485733002/1
6 years, 4 months ago (2014-08-18 15:43:36 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 17:11:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 290274

Powered by Google App Engine
This is Rietveld 408576698