Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(37)

Issue 48573002: [CSS Grid] Do not grow grid tracks when the growth factor has 0 length (Closed)

Created:
6 years, 1 month ago by Xan
Modified:
6 years, 1 month ago
CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@cachetypes
Visibility:
Public.

Description

[CSS Grid] Do not grow grid tracks when the growth factor has 0 length RenderGrid::distributeSpaceToTracks is by far the hottest method in the auto-grid-lots-of-data.html performance test. By reducing useless "growing" of grid tracks when the growth factor is zero we can improve the test time by 3.55% (422 runs/s -> 437 runs/s). BUG=234211 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161354

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove extra space. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M Source/core/rendering/RenderGrid.cpp View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Julien - ping for review
Seems like a micro-optimization but lgtm. https://codereview.chromium.org/48573002/diff/1/Source/core/rendering/RenderGrid.cpp File Source/core/rendering/RenderGrid.cpp (right): https://codereview.chromium.org/48573002/diff/1/Source/core/rendering/RenderGrid.cpp#newcode623 Source/core/rendering/RenderGrid.cpp:623: // We should ...
6 years, 1 month ago (2013-11-05 16:16:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xan@igalia.com/48573002/50001
6 years, 1 month ago (2013-11-05 16:21:46 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2013-11-05 17:23:10 UTC) #3
Message was sent while issue was closed.
Change committed as 161354

Powered by Google App Engine
This is Rietveld 408576698