Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: Source/devtools/front_end/devices/DevicesView.js

Issue 485713002: DevTools: Use targetManager.inspectedPageUrl() instead of resourceTreeModel.inspectedPageUrl() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addrss comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright 2014 The Chromium Authors. All rights reserved. 2 * Copyright 2014 The Chromium Authors. All rights reserved.
3 * Use of this source code is governed by a BSD-style license that can be 3 * Use of this source code is governed by a BSD-style license that can be
4 * found in the LICENSE file. 4 * found in the LICENSE file.
5 */ 5 */
6 6
7 /** 7 /**
8 * @constructor 8 * @constructor
9 * @extends {WebInspector.VBox} 9 * @extends {WebInspector.VBox}
10 */ 10 */
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 158
159 if (incompatibleVersion || browser.adbBrowserChromeVersion < WebInspector.DevicesView.MinVersionNewTab) { 159 if (incompatibleVersion || browser.adbBrowserChromeVersion < WebInspector.DevicesView.MinVersionNewTab) {
160 var warningSection = browserSection.createChild("div", " warning"); 160 var warningSection = browserSection.createChild("div", " warning");
161 warningSection.textContent = incompatibleVersion 161 warningSection.textContent = incompatibleVersion
162 ? WebInspector.UIString("You may need a newer versio n of desktop Chrome. Please try Chrome %s or later.", browser.adbBrowserVersion ) 162 ? WebInspector.UIString("You may need a newer versio n of desktop Chrome. Please try Chrome %s or later.", browser.adbBrowserVersion )
163 : WebInspector.UIString("You may need a newer versio n of Chrome on your device. Please try Chrome %s or later.", WebInspector.Device sView.MinVersionNewTab); 163 : WebInspector.UIString("You may need a newer versio n of Chrome on your device. Please try Chrome %s or later.", WebInspector.Device sView.MinVersionNewTab);
164 } else { 164 } else {
165 var newPageButton = browserSection.createChild("button", "text-button"); 165 var newPageButton = browserSection.createChild("button", "text-button");
166 newPageButton.textContent = WebInspector.UIString("Try h ere"); 166 newPageButton.textContent = WebInspector.UIString("Try h ere");
167 newPageButton.title = WebInspector.UIString("Inspect cur rent page in this browser."); 167 newPageButton.title = WebInspector.UIString("Inspect cur rent page in this browser.");
168 newPageButton.addEventListener("click", InspectorFronten dHost.openUrlOnRemoteDeviceAndInspect.bind(null, browser.id, WebInspector.resour ceTreeModel.inspectedPageURL()), true); 168 newPageButton.addEventListener("click", InspectorFronten dHost.openUrlOnRemoteDeviceAndInspect.bind(null, browser.id, WebInspector.target Manager.inspectedPageURL()), true);
169 } 169 }
170 } 170 }
171 171
172 } 172 }
173 } 173 }
174 }, 174 },
175 175
176 willHide: function() 176 willHide: function()
177 { 177 {
178 InspectorFrontendHost.setDevicesUpdatesEnabled(false); 178 InspectorFrontendHost.setDevicesUpdatesEnabled(false);
179 }, 179 },
180 180
181 wasShown: function() 181 wasShown: function()
182 { 182 {
183 InspectorFrontendHost.setDevicesUpdatesEnabled(true); 183 InspectorFrontendHost.setDevicesUpdatesEnabled(true);
184 }, 184 },
185 185
186 __proto__: WebInspector.VBox.prototype 186 __proto__: WebInspector.VBox.prototype
187 }; 187 };
OLDNEW
« no previous file with comments | « Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js ('k') | Source/devtools/front_end/main/Main.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698