DevTools: Use targetManager.inspectedPageUrl() instead of resourceTreeModel.inspectedPageUrl()

Source/devtools/front_end/sdk/Target.js

 /*
  * Copyright 2014 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /**
  * @constructor
  * @extends {Protocol.Agents}
  * @param {string} name
@@ skipping 242 matching lines @@
     WebInspector.SDKObject.call(this, target);
     target._modelByConstructor.put(modelClass, this);
 }
 
 WebInspector.SDKModel.prototype = {
     __proto__: WebInspector.SDKObject.prototype
 }
 
 /**
  * @constructor
+ * @extends {WebInspector.Object}
  */
 WebInspector.TargetManager = function()
 {
     /** @type {!Array.<!WebInspector.Target>} */
     this._targets = [];
     /** @type {!Array.<!WebInspector.TargetManager.Observer>} */
     this._observers = [];
     /** @type {!Object.<string, !Array.<{modelClass: !Function, thisObject: (!Object|undefined), listener: function(!WebInspector.Event)}>>} */
-    this._listeners = {};
+    this._modelListeners = {};
+}
+
+WebInspector.TargetManager.Events = {
+    InspectedURLChanged: "InspectedURLChanged"
 }
 
 WebInspector.TargetManager.prototype = {
     /**
+     * @return {string}
+     */
+    inspectedPageURL: function()
+    {
+        return this._targets[0].resourceTreeModel.inspectedPageURL();

[pfeldman, 2014/08/18 16:35:20]

I have zero targets. This fails for me.

[sergeyv, 2014/08/18 17:05:51]

Done.

+    },
+
+    /**
+     * @return {string}
+     */
+    inspectedPageDomain: function()
+    {
+        return this._targets[0].resourceTreeModel.inspectedPageDomain();
+    },
+
+    /**
+     * @param {!WebInspector.Event} event
+     */
+    _dispatchInspectedURLChanged: function(event)
+    {
+        this.dispatchEventToListeners(WebInspector.TargetManager.Events.InspectedURLChanged, event.data);
+    },
+
+    /**
      * @param {!Function} modelClass
      * @param {string} eventType
      * @param {function(!WebInspector.Event)} listener
      * @param {!Object=} thisObject
      */
     addModelListener: function(modelClass, eventType, listener, thisObject)
     {
         for (var i = 0; i < this._targets.length; ++i) {
             var model = this._targets[i]._modelByConstructor.get(modelClass);
             model.addEventListener(eventType, listener, thisObject);
         }
-        if (!this._listeners[eventType])
-            this._listeners[eventType] = [];
-        this._listeners[eventType].push({ modelClass: modelClass, thisObject: thisObject, listener: listener });
+        if (!this._modelListeners[eventType])
+            this._modelListeners[eventType] = [];
+        this._modelListeners[eventType].push({ modelClass: modelClass, thisObject: thisObject, listener: listener });
     },
 
     /**
      * @param {!Function} modelClass
      * @param {string} eventType
      * @param {function(!WebInspector.Event)} listener
      * @param {!Object=} thisObject
      */
     removeModelListener: function(modelClass, eventType, listener, thisObject)
     {
-        if (!this._listeners[eventType])
+        if (!this._modelListeners[eventType])
             return;
 
         for (var i = 0; i < this._targets.length; ++i) {
             var model = this._targets[i]._modelByConstructor.get(modelClass);
             model.removeEventListener(eventType, listener, thisObject);
         }
 
-        var listeners = this._listeners[eventType];
+        var listeners = this._modelListeners[eventType];
         for (var i = 0; i < listeners.length; ++i) {
             if (listeners[i].modelClass === modelClass && listeners[i].listener === listener && listeners[i].thisObject === thisObject)
                 listeners.splice(i--, 1);
         }
         if (!listeners.length)
-            delete this._listeners[eventType];
+            delete this._modelListeners[eventType];
     },
 
     /**
      * @param {!WebInspector.TargetManager.Observer} targetObserver
      */
     observeTargets: function(targetObserver)
     {
         this.targets().forEach(targetObserver.targetAdded.bind(targetObserver));
         this._observers.push(targetObserver);
     },
@@ skipping 26 matching lines @@
                 callback(newTarget);
         }
     },
 
     /**
      * @param {!WebInspector.Target} target
      */
     addTarget: function(target)
     {
         this._targets.push(target);
+        if (this._targets.length === 1)
+            target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.InspectedURLChanged, this._dispatchInspectedURLChanged, this);
+
         var copy = this._observers.slice();
         for (var i = 0; i < copy.length; ++i)
             copy[i].targetAdded(target);
 
-        for (var eventType in this._listeners) {
-            var listeners = this._listeners[eventType];
+        for (var eventType in this._modelListeners) {
+            var listeners = this._modelListeners[eventType];
             for (var i = 0; i < listeners.length; ++i) {
                 var model = target._modelByConstructor.get(listeners[i].modelClass);
                 model.addEventListener(eventType, listeners[i].listener, listeners[i].thisObject);
             }
         }
     },
 
     /**
      * @param {!WebInspector.Target} target
      */
     removeTarget: function(target)
     {
         this._targets.remove(target);
+        if (this._targets.length === 0)
+            target.resourceTreeModel.removeEventListener(WebInspector.ResourceTreeModel.EventTypes.InspectedURLChanged, this._dispatchInspectedURLChanged, this);
+
         var copy = this._observers.slice();
         for (var i = 0; i < copy.length; ++i)
             copy[i].targetRemoved(target);
 
-        for (var eventType in this._listeners) {
-            var listeners = this._listeners[eventType];
+        for (var eventType in this._modelListeners) {
+            var listeners = this._modelListeners[eventType];
             for (var i = 0; i < listeners.length; ++i) {
                 var model = target._modelByConstructor.get(listeners[i].modelClass);
                 model.removeEventListener(eventType, listeners[i].listener, listeners[i].thisObject);
             }
         }
     },
 
     /**
      * @return {!Array.<!WebInspector.Target>}
      */
     targets: function()
     {
         return this._targets.slice();
     },
 
     /**
      * @return {?WebInspector.Target}
      */
     mainTarget: function()
     {
         return this._targets[0];
-    }
+    },
+
+    __proto__: WebInspector.Object.prototype
 }
 
 /**
  * @interface
  */
 WebInspector.TargetManager.Observer = function()
 {
 }
 
 WebInspector.TargetManager.Observer.prototype = {
     /**
      * @param {!WebInspector.Target} target
      */
     targetAdded: function(target) { },
 
     /**
      * @param {!WebInspector.Target} target
      */
     targetRemoved: function(target) { },
 }
 
 /**
  * @type {!WebInspector.TargetManager}
  */
 WebInspector.targetManager = new WebInspector.TargetManager();