Issue 485713002: DevTools: Use targetManager.inspectedPageUrl() instead of resourceTreeModel.inspectedPageUrl()

Issue 485713002: DevTools: Use targetManager.inspectedPageUrl() instead of resourceTreeModel.inspectedPageUrl() (Closed)

Created:
6 years, 4 months ago by sergeyv

Modified:
6 years, 4 months ago

Reviewers:
vsevik, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Use targetManager.inspectedPageUrl() instead of resourceTreeModel.inspectedPageUrl() BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180479

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addrss comments #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -26 lines)			Patch
M	LayoutTests/inspector/sources/debugger/breakpoint-manager.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/inspector/sources/debugger/file-system-project-mapping.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/bindings/ResourceUtils.js	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/devices/DevicesView.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/main/Main.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/network/NetworkPanel.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/sdk/Target.js	View	1	8 chunks	+55 lines, -12 lines	0 comments	Download
M	Source/devtools/front_end/sources/NavigatorView.js	View	1	4 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://codereview.chromium.org/485713002/diff/1/Source/devtools/front_end/sdk/Target.js File Source/devtools/front_end/sdk/Target.js (right): https://codereview.chromium.org/485713002/diff/1/Source/devtools/front_end/sdk/Target.js#newcode285 Source/devtools/front_end/sdk/Target.js:285: return this._targets[0].resourceTreeModel.inspectedPageURL(); I have zero targets. This fails ...

6 years, 4 months ago (2014-08-18 16:35:20 UTC) #2

sergeyv

https://codereview.chromium.org/485713002/diff/1/Source/devtools/front_end/sdk/Target.js File Source/devtools/front_end/sdk/Target.js (right): https://codereview.chromium.org/485713002/diff/1/Source/devtools/front_end/sdk/Target.js#newcode285 Source/devtools/front_end/sdk/Target.js:285: return this._targets[0].resourceTreeModel.inspectedPageURL(); On 2014/08/18 16:35:20, pfeldman wrote: > I ...

6 years, 4 months ago (2014-08-18 17:05:51 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/485713002/20001

6 years, 4 months ago (2014-08-18 17:06:25 UTC) #5

commit-bot: I haz the power

Committed patchset #2 (20001) as 180479

6 years, 4 months ago (2014-08-18 18:04:45 UTC) #6

dglazkov

On 2014/08/18 at 18:04:45, commit-bot wrote: > Committed patchset #2 (20001) as 180479 This test ...

6 years, 4 months ago (2014-08-18 21:01:07 UTC) #7

sergeyv

6 years, 4 months ago (2014-08-19 07:29:18 UTC) #8

Message was sent while issue was closed.

On 2014/08/18 21:01:07, dglazkov wrote:
> On 2014/08/18 at 18:04:45, commit-bot wrote:
> > Committed patchset #2 (20001) as 180479
> 
> This test is suddenly showing a line number in the exception. Could this be
due
> to this patch?
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@To...

No, this patch doesn't touch any console related code.

Expand Messages | Collapse Messages