Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 485663003: Non-destructive editing of git cache config. (Closed)

Created:
6 years, 4 months ago by szager1
Modified:
6 years, 4 months ago
Reviewers:
agable, iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Project:
tools
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M git_cache.py View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
szager1
6 years, 4 months ago (2014-08-19 20:47:47 UTC) #1
iannucci
lgtm https://codereview.chromium.org/485663003/diff/1/git_cache.py File git_cache.py (right): https://codereview.chromium.org/485663003/diff/1/git_cache.py#newcode246 git_cache.py:246: '+refs/heads/*:refs/heads/*', '\\+refs/heads/\\*:.*'], cwd=cwd) let's use r"raw strings" to ...
6 years, 4 months ago (2014-08-19 20:58:55 UTC) #2
szager1
https://codereview.chromium.org/485663003/diff/1/git_cache.py File git_cache.py (right): https://codereview.chromium.org/485663003/diff/1/git_cache.py#newcode246 git_cache.py:246: '+refs/heads/*:refs/heads/*', '\\+refs/heads/\\*:.*'], cwd=cwd) On 2014/08/19 20:58:55, iannucci wrote: > ...
6 years, 4 months ago (2014-08-19 21:15:48 UTC) #3
szager1
The CQ bit was checked by szager@chromium.org
6 years, 4 months ago (2014-08-19 21:16:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/485663003/20001
6 years, 4 months ago (2014-08-19 21:16:41 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 21:19:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 290665

Powered by Google App Engine
This is Rietveld 408576698