Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 485663002: Revert of Remove the acclerated overflow scroll and fixed root background flags. (Closed)

Created:
6 years, 4 months ago by Mike West
Modified:
6 years, 4 months ago
Reviewers:
danakj, piman
CC:
chromium-reviews, creis+watch_chromium.org, nkostylev+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, abarth-chromium, Ian Vollick
Project:
chromium
Visibility:
Public.

Description

Revert of Remove the acclerated overflow scroll and fixed root background flags. (patchset #1 of https://codereview.chromium.org/479673003/) Reason for revert: This seems to have broken most of the virtual/gpu/compositedscrolling/overflow. See http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/35692 and http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/10128 for examples. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=virtual/gpu/compositedscrolling/overflow/content-gains-scrollbars.html,virtual/gpu/compositedscrolling/overflow/nested-render-surfaces-with-intervening-clip.html,virtual/gpu/compositedscrolling/overflow/nested-render-surfaces-with-rotation.html,virtual/gpu/compositedscrolling/overflow/nested-render-surfaces.html,virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle.html,virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch.html,virtual/gpu/compositedscrolling/overflow/overflow-overlay-with-touch.html,virtual/gpu/compositedscrolling/overflow/overflow-scrollbar-layers.html,virtual/gpu/compositedscrolling/scrollbars/overflow-scrollbar-combinations.html shows all the tests. Original issue's description: > Remove the acclerated overflow scroll and fixed root background flags. > > These flags are merged into --{dis,en}able-prefer-compositing-to-lcd-text > which controls these along with fixed position. > > Depends on https://codereview.chromium.org/479653003/. > > R=aelias, piman@chromium.org > BUG=365851 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290218 TBR=piman@chromium.org,danakj@chromium.org NOTREECHECKS=true NOTRY=true BUG=365851 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290233

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -7 lines) Patch
M chrome/browser/about_flags.cc View 3 chunks +23 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/android/content_startup_flags.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 4 chunks +31 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mike West
Created Revert of Remove the acclerated overflow scroll and fixed root background flags.
6 years, 4 months ago (2014-08-18 10:52:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/485663002/1
6 years, 4 months ago (2014-08-18 10:53:15 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 10:54:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (1) as 290233

Powered by Google App Engine
This is Rietveld 408576698