Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 485643002: [DevTools] Add Chrome for iOS user agent presets. (Closed)

Created:
6 years, 4 months ago by dgozman
Modified:
6 years, 4 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Add Chrome for iOS user agent presets. BUG=403289 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180472

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/devtools/front_end/toolbox/OverridesUI.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dgozman
Take a look please.
6 years, 4 months ago (2014-08-18 09:10:31 UTC) #1
pfeldman
We should not do this - Chrome \u2014 iPad has nothing to do with the ...
6 years, 4 months ago (2014-08-18 14:39:22 UTC) #2
dgozman
On 2014/08/18 14:39:22, pfeldman wrote: > We should not do this - Chrome \u2014 iPad ...
6 years, 4 months ago (2014-08-18 14:57:49 UTC) #3
pfeldman
lgtm
6 years, 4 months ago (2014-08-18 15:19:45 UTC) #4
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 4 months ago (2014-08-18 15:20:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/485643002/1
6 years, 4 months ago (2014-08-18 15:21:02 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 16:24:33 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (1) as 180472

Powered by Google App Engine
This is Rietveld 408576698