Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1351)

Issue 485623002: ImageSource misc cleanup (Closed)

Created:
6 years, 4 months ago by Noel Gordon
Modified:
6 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Project:
blink
Visibility:
Public.

Description

ImageSource misc cleanup Remove unused includes, simplify and clarify a comment, format the frameBytesAtIndex() code like the rest of the code in this file. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180434

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M Source/platform/graphics/ImageSource.cpp View 3 chunks +3 lines, -9 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
Noel Gordon
6 years, 4 months ago (2014-08-18 07:27:04 UTC) #1
tkent
lgtm https://codereview.chromium.org/485623002/diff/1/Source/platform/graphics/ImageSource.cpp File Source/platform/graphics/ImageSource.cpp (right): https://codereview.chromium.org/485623002/diff/1/Source/platform/graphics/ImageSource.cpp#newcode58 Source/platform/graphics/ImageSource.cpp:58: // Create a decoder by sniffing the encoded ...
6 years, 4 months ago (2014-08-18 07:31:00 UTC) #2
Noel Gordon
https://codereview.chromium.org/485623002/diff/1/Source/platform/graphics/ImageSource.cpp File Source/platform/graphics/ImageSource.cpp (right): https://codereview.chromium.org/485623002/diff/1/Source/platform/graphics/ImageSource.cpp#newcode58 Source/platform/graphics/ImageSource.cpp:58: // Create a decoder by sniffing the encoded data. ...
6 years, 4 months ago (2014-08-18 07:54:50 UTC) #3
Noel Gordon
The CQ bit was checked by noel@chromium.org
6 years, 4 months ago (2014-08-18 07:54:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noel@chromium.org/485623002/1
6 years, 4 months ago (2014-08-18 07:55:53 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-18 08:29:40 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 08:42:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as 180434

Powered by Google App Engine
This is Rietveld 408576698