Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 485603002: [gcc 4.8] Explicitly initialize net_error in ProxyRetryInfo to fix build failure (Closed)

Created:
6 years, 4 months ago by vivekg_samsung
Modified:
6 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[gcc 4.8] Explicitly initialize net_error in ProxyRetryInfo to fix build failure gcc 4.8 reports build failure as net_error is not explicitly initialized. The error thrown is as below - net/proxy/proxy_retry_info.h: In member function ‘virtual void net::{anonymous}::ProxyListTest_DeprioritizeBadProxies_Test::TestBody()’: net/proxy/proxy_retry_info.h:15:8: error: ‘proxy_retry_info.net::ProxyRetryInfo::net_error’ is used uninitialized in this function [-Werror=uninitialized] R=kundaji@chromium.org, rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290239

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/proxy/proxy_retry_info.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
vivekg
PTAL, thank you!
6 years, 4 months ago (2014-08-18 04:58:56 UTC) #1
Ryan Sleevi
https://codereview.chromium.org/485603002/diff/1/net/proxy/proxy_retry_info.h File net/proxy/proxy_retry_info.h (right): https://codereview.chromium.org/485603002/diff/1/net/proxy/proxy_retry_info.h#newcode11 net/proxy/proxy_retry_info.h:11: #include "net/base/net_errors.h" Don't include this, and init to zero.
6 years, 4 months ago (2014-08-18 05:51:12 UTC) #2
vivekg
On 2014/08/18 05:51:12, Ryan Sleevi wrote: > https://codereview.chromium.org/485603002/diff/1/net/proxy/proxy_retry_info.h > File net/proxy/proxy_retry_info.h (right): > > https://codereview.chromium.org/485603002/diff/1/net/proxy/proxy_retry_info.h#newcode11 ...
6 years, 4 months ago (2014-08-18 05:59:51 UTC) #3
Ryan Sleevi
The CQ bit was checked by rsleevi@chromium.org
6 years, 4 months ago (2014-08-18 06:05:57 UTC) #4
Ryan Sleevi
lgtm
6 years, 4 months ago (2014-08-18 06:05:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/485603002/20001
6 years, 4 months ago (2014-08-18 06:06:45 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-18 07:51:18 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-18 08:53:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/6578)
6 years, 4 months ago (2014-08-18 08:53:21 UTC) #9
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 4 months ago (2014-08-18 10:00:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/485603002/20001
6 years, 4 months ago (2014-08-18 10:01:12 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 12:34:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (20001) as 290239

Powered by Google App Engine
This is Rietveld 408576698