Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 485553002: When LCD disabled, enable compositing features that interact with LCD. (Closed)

Created:
6 years, 4 months ago by danakj
Modified:
6 years, 4 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, enne (OOO), abarth-chromium, Ian Vollick
Project:
chromium
Visibility:
Public.

Description

When LCD disabled, enable compositing features that interact with LCD. When LCD text is not being used, allow layer promotion that would have otherwise disabled LCD text for the layer. This makes the PreferCompositingToLCDText setting behave the way the UseCompositedScrollingForFrames setting was previously working, so that when we merge it in, we don't lose the benefits of disabling LCD text for iframes, and we'll gain more benefits elsewhere. R=piman@chromium.org BUG=365851 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290335

Patch Set 1 : prefer-compositing-lcd-disabled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/renderer/render_view_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
danakj
6 years, 4 months ago (2014-08-17 21:53:48 UTC) #1
piman
lgtm
6 years, 4 months ago (2014-08-18 17:32:30 UTC) #2
piman
lgtm lgtm
6 years, 4 months ago (2014-08-18 17:32:30 UTC) #3
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 4 months ago (2014-08-18 18:03:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/485553002/1
6 years, 4 months ago (2014-08-18 18:04:13 UTC) #5
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 4 months ago (2014-08-18 18:38:31 UTC) #6
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 4 months ago (2014-08-18 18:38:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/485553002/1
6 years, 4 months ago (2014-08-18 18:38:47 UTC) #8
danakj
Committed patchset #1 manually as 290335 (presubmit successful).
6 years, 4 months ago (2014-08-18 19:39:46 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 19:40:03 UTC) #10
Message was sent while issue was closed.
Failed to commit the patch.
Sending        content/renderer/render_view_impl.cc
Transmitting file data .svn: Commit failed (details follow):
svn: File '/trunk/src/content/renderer/render_view_impl.cc' is out of date

Powered by Google App Engine
This is Rietveld 408576698