Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 48553003: Fix thumbnails in the guest mode. (Closed)

Created:
7 years, 1 month ago by mtomasz
Modified:
7 years, 1 month ago
Reviewers:
yoshiki
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Fix thumbnails in the guest mode. In the guest mode, thumbnails were not loaded, because the token was unavailable, since Drive is disabled for the guest mode. Actually, the token is not necessary at all for local resources, therefore it should not be used. This patch avoids fetching the token for local resources, what solves the problem. TEST=Tested manually. Thumbnails work in the guest mode. BUG=311212 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232961

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M chrome/browser/resources/image_loader/request.js View 1 4 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
mtomasz
@yoshiki: PTAL.
7 years, 1 month ago (2013-11-01 08:33:36 UTC) #1
yoshiki
lgtm with nit https://codereview.chromium.org/48553003/diff/1/chrome/browser/resources/image_loader/request.js File chrome/browser/resources/image_loader/request.js (right): https://codereview.chromium.org/48553003/diff/1/chrome/browser/resources/image_loader/request.js#newcode299 chrome/browser/resources/image_loader/request.js:299: AuthorizedXHR.loadWithToken_ = function(token, url, onSuccess, onFailure) ...
7 years, 1 month ago (2013-11-01 09:33:55 UTC) #2
yoshiki
https://codereview.chromium.org/48553003/diff/1/chrome/browser/resources/image_loader/request.js File chrome/browser/resources/image_loader/request.js (right): https://codereview.chromium.org/48553003/diff/1/chrome/browser/resources/image_loader/request.js#newcode299 chrome/browser/resources/image_loader/request.js:299: AuthorizedXHR.loadWithToken_ = function(token, url, onSuccess, onFailure) { On 2013/11/01 ...
7 years, 1 month ago (2013-11-01 09:34:17 UTC) #3
mtomasz
https://codereview.chromium.org/48553003/diff/1/chrome/browser/resources/image_loader/request.js File chrome/browser/resources/image_loader/request.js (right): https://codereview.chromium.org/48553003/diff/1/chrome/browser/resources/image_loader/request.js#newcode299 chrome/browser/resources/image_loader/request.js:299: AuthorizedXHR.loadWithToken_ = function(token, url, onSuccess, onFailure) { On 2013/11/01 ...
7 years, 1 month ago (2013-11-05 00:50:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/48553003/60001
7 years, 1 month ago (2013-11-05 00:55:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/48553003/60001
7 years, 1 month ago (2013-11-05 03:04:38 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-05 04:13:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/48553003/60001
7 years, 1 month ago (2013-11-05 05:20:05 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-05 05:39:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/48553003/60001
7 years, 1 month ago (2013-11-05 05:46:39 UTC) #10
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 13:45:30 UTC) #11
Message was sent while issue was closed.
Change committed as 232961

Powered by Google App Engine
This is Rietveld 408576698