Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 485523004: GN: Mojo wget, sample_app, surfaces app and component build (Closed)

Created:
6 years, 4 months ago by jamesr
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, cc-bugs_chromium.org
Project:
chromium
Visibility:
Public.

Description

GN: Mojo wget, sample_app, surfaces app and component build This makes mojo_shell, mojo_shell_tests and the wget, sample_app and surfaces_app samples work along with their dependent services. R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290689

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -44 lines) Patch
M mojo/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/cc/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/common/BUILD.gn View 2 chunks +4 lines, -3 lines 0 comments Download
A + mojo/examples/BUILD.gn View 1 chunk +5 lines, -7 lines 0 comments Download
A mojo/examples/echo/BUILD.gn View 1 chunk +52 lines, -0 lines 0 comments Download
A mojo/examples/sample_app/BUILD.gn View 1 chunk +28 lines, -0 lines 0 comments Download
A mojo/examples/surfaces_app/BUILD.gn View 1 chunk +96 lines, -0 lines 0 comments Download
A + mojo/examples/wget/BUILD.gn View 1 chunk +12 lines, -11 lines 0 comments Download
M mojo/gles2/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
M mojo/mojo_examples.gypi View 5 chunks +5 lines, -3 lines 0 comments Download
M mojo/mojo_services.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/public/gles2/BUILD.gn View 2 chunks +12 lines, -4 lines 0 comments Download
M mojo/services/BUILD.gn View 1 chunk +5 lines, -3 lines 0 comments Download
M mojo/services/native_viewport/BUILD.gn View 2 chunks +5 lines, -1 line 0 comments Download
M mojo/services/network/BUILD.gn View 1 chunk +17 lines, -1 line 0 comments Download
M mojo/services/public/cpp/geometry/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A mojo/services/public/cpp/surfaces/BUILD.gn View 1 chunk +36 lines, -0 lines 0 comments Download
A mojo/services/surfaces/BUILD.gn View 1 chunk +32 lines, -0 lines 0 comments Download
M mojo/services/view_manager/BUILD.gn View 3 chunks +2 lines, -3 lines 0 comments Download
M mojo/shell/BUILD.gn View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/system.gni View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
6 years, 4 months ago (2014-08-19 20:22:28 UTC) #1
brettw
lgtm
6 years, 4 months ago (2014-08-19 21:12:40 UTC) #2
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-19 21:13:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/485523004/1
6 years, 4 months ago (2014-08-19 21:14:00 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-19 21:57:47 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 23:18:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 290689

Powered by Google App Engine
This is Rietveld 408576698