Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 485523003: Revert 290617 "Skia roll de21804:94ce9ac" (Closed)

Created:
6 years, 4 months ago by viettrungluu
Modified:
6 years, 4 months ago
Reviewers:
skia-deps-roller
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 290617 "Skia roll de21804:94ce9ac" Broke ASan/LSan: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/6376 @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@Direct leak of 136 byte(s) in 1 object(s) allocated from:@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #0 0x4f295b in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/browser_tests+0x4f295b)@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #1 0x4f41e33 in GrGpuGL::onCreateIndexBuffer(unsigned long, bool) third_party/skia/src/gpu/gl/GrGpuGL.cpp:1374:13@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #2 0x4ec41b3 in createIndexBuffer third_party/skia/src/gpu/GrGpu.cpp:159:12@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #3 0x4ec41b3 in GrGpu::getQuadIndexBuffer() const third_party/skia/src/gpu/GrGpu.cpp:273@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #4 0x4ecbad0 in GrInOrderDrawBuffer::onDrawRect(SkRect const&, SkRect const*, SkMatrix const*) third_party/skia/src/gpu/GrInOrderDrawBuffer.cpp:174:34@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #5 0x4e998f8 in drawRect third_party/skia/src/gpu/GrDrawTarget.h:384:9@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #6 0x4e998f8 in drawSimpleRect third_party/skia/src/gpu/GrDrawTarget.h:391@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #7 0x4e998f8 in GrContext::drawRect(GrPaint const&, SkRect const&, GrStrokeInfo const*) third_party/skia/src/gpu/GrContext.cpp:904@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #8 0xf895e0c in SkAlphaThresholdFilterImpl::asNewEffect(GrEffect**, GrTexture*, SkMatrix const&, SkIRect const&) const third_party/skia/src/effects/SkAlphaThresholdFilter.cpp:287:17@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #9 0x4d531c9 in SkImageFilter::filterImageGPU(SkImageFilter::Proxy*, SkBitmap const&, SkImageFilter::Context const&, SkBitmap*, SkIPoint*) const third_party/skia/src/core/SkImageFilter.cpp:272:5@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #10 0xf8b4aad in filter_texture(SkBaseDevice*, GrContext*, GrTexture*, SkImageFilter const*, int, int, SkImageFilter::Context const&, SkBitmap*, SkIPoint*) third_party/skia/src/gpu/SkGpuDevice.cpp:1398:16@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #11 0xf8b3d42 in SkGpuDevice::drawSprite(SkDraw const&, SkBitmap const&, int, int, SkPaint const&) third_party/skia/src/gpu/SkGpuDevice.cpp:1434:13@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #12 0x4d16942 in SkCanvas::drawSprite(SkBitmap const&, int, int, SkPaint const*) third_party/skia/src/core/SkCanvas.cpp:1194:13@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #13 0xe2828c3 in cc::ApplyImageFilter(scoped_ptr\u003Ccc::GLRenderer::ScopedUseGrContext, base::DefaultDeleter\u003Ccc::GLRenderer::ScopedUseGrContext> >, cc::ResourceProvider*, gfx::Point const&, gfx::Vector2dF const&, SkImageFilter*, cc::ScopedResource*) cc/output/gl_renderer.cc:722:3@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #14 0xe275474 in cc::GLRenderer::DrawRenderPassQuad(cc::DirectRenderer::DrawingFrame*, cc::RenderPassDrawQuad const*) cc/output/gl_renderer.cc:1051:13@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #15 0xe4598a4 in cc::DirectRenderer::DrawRenderPass(cc::DirectRenderer::DrawingFrame*, cc::RenderPass const*) cc/output/direct_renderer.cc:385:7@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #16 0xe458480 in cc::DirectRenderer::DrawFrame(cc::ScopedPtrVector\u003Ccc::RenderPass>*, float, gfx::Rect const&, gfx::Rect const&, bool) cc/output/direct_renderer.cc:232:5@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #17 0xe3bd5cc in cc::LayerTreeHostImpl::DrawLayers(cc::LayerTreeHostImpl::FrameData*, base::TimeTicks) cc/trees/layer_tree_host_impl.cc:1578:5@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #18 0xe3fb78e in cc::SingleThreadProxy::DoComposite(base::TimeTicks, cc::LayerTreeHostImpl::FrameData*) cc/trees/single_thread_proxy.cc:438:7@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #19 0xe3fade5 in cc::SingleThreadProxy::CompositeImmediately(base::TimeTicks) cc/trees/single_thread_proxy.cc:356:7@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #20 0x651589b in ui::Compositor::Draw() ui/compositor/compositor.cc:234:5@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #21 0x345c43f in Run base/callback.h:401:12@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #22 0x345c43f in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #23 0x339b64c in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:435:3@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #24 0x339c710 in DeferOrRunPendingTask base/message_loop/message_loop.cc:445:5@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #25 0x339c710 in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:552@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #26 0x3445422 in HandleDispatch base/message_loop/message_pump_glib.cc:267:7@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #27 0x3445422 in base::(anonymous namespace)::WorkSourceDispatch(_GSource*, int (*)(void*), void*) base/message_loop/message_pump_glib.cc:109@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #28 0x7f5f9395dd12 in g_main_dispatch /build/buildd/glib2.0-2.32.4/./glib/gmain.c:2539@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #29 0x7f5f9395dd12 in g_main_context_dispatch /build/buildd/glib2.0-2.32.4/./glib/gmain.c:3075@@@ > Skia roll de21804:94ce9ac > > https://skia.googlesource.com/skia/+log/de218041b99e8f9af0e80b34452b0e8d7f770765..94ce9ac8624dbb45656b8f5c992fad9c9ff3ee5f > > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel > TBR=caryclark@google.com > BUG= > > Review URL: https://codereview.chromium.org/485173003 TBR=skia-deps-roller@chromium.org,caryclark@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290648

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M trunk/src/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
viettrungluu
6 years, 4 months ago (2014-08-19 20:12:44 UTC) #1
viettrungluu
6 years, 4 months ago (2014-08-19 20:13:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r290648.

Powered by Google App Engine
This is Rietveld 408576698