Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 485503002: DevTools: support getters and setters in javascript outline (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 4 months ago
Reviewers:
apavlov, vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: support getters and setters in javascript outline BUG=339798 R=vsevik, apavlov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180469

Patch Set 1 #

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -4 lines) Patch
M LayoutTests/inspector/sources/debugger/script-extract-outline.html View 2 chunks +54 lines, -3 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/script-extract-outline-expected.txt View 1 chunk +30 lines, -0 lines 0 comments Download
M Source/devtools/front_end/script_formatter_worker/ScriptFormatterWorker.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
lushnikov
ptal
6 years, 4 months ago (2014-08-17 11:50:18 UTC) #1
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 4 months ago (2014-08-18 05:39:54 UTC) #2
vsevik
lgtm
6 years, 4 months ago (2014-08-18 05:39:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/485503002/1
6 years, 4 months ago (2014-08-18 05:40:04 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-18 06:41:57 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-18 06:49:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/20139)
6 years, 4 months ago (2014-08-18 06:49:56 UTC) #7
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 4 months ago (2014-08-18 14:34:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/485503002/20001
6 years, 4 months ago (2014-08-18 14:35:18 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 15:43:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180469

Powered by Google App Engine
This is Rietveld 408576698