Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 485483003: Revert of Omnibox: Make URLs of Bookmarks Searchable (Closed)

Created:
6 years, 4 months ago by Evan Stade
Modified:
6 years, 4 months ago
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, tfarina, haitaol+watch_chromium.org, browser-components-watch_chromium.org, James Su, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Omnibox: Make URLs of Bookmarks Searchable (patchset #2 of https://codereview.chromium.org/489373005/) Reason for revert: Broke interactive_ui_tests on mac: https://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20(dbg)(1)/builds/52199 Original issue's description: > Omnibox: Make URLs of Bookmarks Searchable > > This used to be controlled by a field trial created in > https://codereview.chromium.org/184663002 > > After evaluating this change, we've decided to launch it. > This change turns the flag on by default and removes the field trial code. > It also removes the index_urls_ parameters everywhere because those will > always be true forevermore. > > I tested this interactively. > Also, all the unit tests still apparently pass. And yes some of these do > exercise this feature. > > TBR=joaodasilva > (for trivial change to components/policy/core/browser/managed_bookmarks_tracker_unittest.cc ) > > BUG=157204, 378854 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291445 TBR=pkasting@google.com,sky@chromium.org,pkasting@chromium.org,mpearson@chromium.org NOTREECHECKS=true NOTRY=true BUG=157204, 378854 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -120 lines) Patch
M chrome/browser/autocomplete/bookmark_provider.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/bookmark_provider.cc View 5 chunks +27 lines, -19 lines 0 comments Download
M chrome/browser/autocomplete/bookmark_provider_unittest.cc View 6 chunks +28 lines, -26 lines 0 comments Download
M chrome/browser/bookmarks/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model_factory.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_editor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_codec_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M components/bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_index.h View 2 chunks +7 lines, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_index.cc View 5 chunks +34 lines, -23 lines 0 comments Download
M components/bookmarks/browser/bookmark_index_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M components/bookmarks/browser/bookmark_model.h View 2 chunks +7 lines, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_model.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_model_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/bookmarks/browser/bookmark_node_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_utils_unittest.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M components/bookmarks/test/test_bookmark_client.h View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/test/test_bookmark_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_utils_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/enhanced_bookmarks/metadata_accessor_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M components/omnibox/omnibox_field_trial.h View 2 chunks +12 lines, -0 lines 0 comments Download
M components/omnibox/omnibox_field_trial.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M components/policy/core/browser/managed_bookmarks_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Stade
Created Revert of Omnibox: Make URLs of Bookmarks Searchable
6 years, 4 months ago (2014-08-22 20:35:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/485483003/1
6 years, 4 months ago (2014-08-22 20:35:25 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 20:37:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (1) as 291496

Powered by Google App Engine
This is Rietveld 408576698