Extracted method to CreateSinglePageRasterPdf() to simplify PrintPagesAsRasterPDF().

Extracted method to CreateSinglePageRasterPdf() to simplify PrintPagesAsRasterPDF().
Fixed page passed into FPDFPageObj_NewImgeObj().

BUG=385119
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290780

[Lei Zhang, 2014-08-20 00:43:26]

lgtm

[Bo Xu, 2014-08-20 00:44:39]

On 2014/08/20 00:43:26, Lei Zhang wrote:
> lgtm

lgtm

[Bo Xu, 2014-08-20 00:50:48]

https://codereview.chromium.org/485413002/diff/40001/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/485413002/diff/40001/pdf/pdfium/pdfium_engine...
pdf/pdfium/pdfium_engine.cc:1032: FPDF_PAGEOBJECT temp_img =
FPDFPageObj_NewImgeObj(temp_page);
here should be 

FPDF_PAGEOBJECT temp_img = FPDFPageObj_NewImgeObj(temp_doc);

[Vitaly Buka (NO REVIEWS), 2014-08-20 01:43:40]

https://codereview.chromium.org/485413002/diff/40001/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/485413002/diff/40001/pdf/pdfium/pdfium_engine...
pdf/pdfium/pdfium_engine.cc:1032: FPDF_PAGEOBJECT temp_img =
FPDFPageObj_NewImgeObj(temp_page);
On 2014/08/20 00:50:48, Bo Xu wrote:
> here should be 
> 
> FPDF_PAGEOBJECT temp_img = FPDFPageObj_NewImgeObj(temp_doc);

Done. this also didn't crash :-)

https://codereview.chromium.org/485413002/diff/60001/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/485413002/diff/60001/pdf/pdfium/pdfium_engine...
pdf/pdfium/pdfium_engine.cc:1108: PDFiumMemBufferFileRead
file_read(buffer.data(), buffer.size());
Moved out flattening, because buffer must be alive.

[Vitaly Buka (NO REVIEWS), 2014-08-20 01:43:45]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-08-20 01:44:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/485413002/60001

[Bo Xu, 2014-08-20 03:21:26]

https://codereview.chromium.org/485413002/diff/60001/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/485413002/diff/60001/pdf/pdfium/pdfium_engine...
pdf/pdfium/pdfium_engine.cc:1108: PDFiumMemBufferFileRead
file_read(buffer.data(), buffer.size());
On 2014/08/20 01:43:40, Vitaly Buka wrote:
> Moved out flattening, because buffer must be alive.

Just curious why buffer has to be alive here? Because temp_doc still uses
buffer?

[Vitaly Buka (NO REVIEWS), 2014-08-20 05:39:01]

https://codereview.chromium.org/485413002/diff/60001/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/485413002/diff/60001/pdf/pdfium/pdfium_engine...
pdf/pdfium/pdfium_engine.cc:1108: PDFiumMemBufferFileRead
file_read(buffer.data(), buffer.size());
On 2014/08/20 03:21:26, Bo Xu wrote:
> On 2014/08/20 01:43:40, Vitaly Buka wrote:
> > Moved out flattening, because buffer must be alive.
> 
> Just curious why buffer has to be alive here? Because temp_doc still uses
> buffer?

yes

[commit-bot: I haz the power, 2014-08-20 06:51:33]

Committed patchset #4 (60001) as 290780