Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: tools/bisect-perf-regression.py

Issue 485363002: Fix Attribute error cause due to recent refactor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Performance Test Bisect Tool 6 """Performance Test Bisect Tool
7 7
8 This script bisects a series of changelists using binary search. It starts at 8 This script bisects a series of changelists using binary search. It starts at
9 a bad revision where a performance metric has regressed, and asks for a last 9 a bad revision where a performance metric has regressed, and asks for a last
10 known-good revision. It will then binary search across this revision range by 10 known-good revision. It will then binary search across this revision range by
(...skipping 1833 matching lines...) Expand 10 before | Expand all | Expand 10 after
1844 return self.PerformCrosChrootCleanup() 1844 return self.PerformCrosChrootCleanup()
1845 return True 1845 return True
1846 1846
1847 def RunPostSync(self, depot): 1847 def RunPostSync(self, depot):
1848 """Performs any work after syncing. 1848 """Performs any work after syncing.
1849 1849
1850 Returns: 1850 Returns:
1851 True if successful. 1851 True if successful.
1852 """ 1852 """
1853 if self.opts.target_platform == 'android': 1853 if self.opts.target_platform == 'android':
1854 if not bisect_utils.SetupAndroidBuildEnvironment(self.opts, 1854 if not builder.SetupAndroidBuildEnvironment(self.opts,
1855 path_to_src=self.src_cwd): 1855 path_to_src=self.src_cwd):
1856 return False 1856 return False
1857 1857
1858 if depot == 'cros': 1858 if depot == 'cros':
1859 return self.CreateCrosChroot() 1859 return self.CreateCrosChroot()
1860 else: 1860 else:
1861 return self.RunGClientHooks() 1861 return self.RunGClientHooks()
1862 return True 1862 return True
1863 1863
1864 def ShouldSkipRevision(self, depot, revision): 1864 def ShouldSkipRevision(self, depot, revision):
(...skipping 1491 matching lines...) Expand 10 before | Expand all | Expand 10 after
3356 # bugs. If you change this, please update the perf dashboard as well. 3356 # bugs. If you change this, please update the perf dashboard as well.
3357 bisect_utils.OutputAnnotationStepStart('Results') 3357 bisect_utils.OutputAnnotationStepStart('Results')
3358 print 'Error: %s' % e.message 3358 print 'Error: %s' % e.message
3359 if opts.output_buildbot_annotations: 3359 if opts.output_buildbot_annotations:
3360 bisect_utils.OutputAnnotationStepClosed() 3360 bisect_utils.OutputAnnotationStepClosed()
3361 return 1 3361 return 1
3362 3362
3363 3363
3364 if __name__ == '__main__': 3364 if __name__ == '__main__':
3365 sys.exit(main()) 3365 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698