Simplify TypingCommand::makeEditableRootEmpty() a bit

Simplify TypingCommand::makeEditableRootEmpty() a bit

Simplify TypingCommand::makeEditableRootEmpty() a bit by avoiding an unnecessary
call to ElementTraversal::firstWithin().

In this if scope, we already know that the root node has a single child.
Therefore, there is no reason to do a tree traversal, we can directly call
ContainerNode::firstChild().

ElementTraversal::firstWithin() never explores descendants and only looks
for the first direct child that is an Element. In this case, we don't need to
check if the child is an Element as we can pass a Node to isHTMLBRElement().

R=leviw@chromium.org, yosin@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180673

[yosin_UTC9, 2014-08-20 00:50:36]

LGTM

Make sense. Thanks for clean up.
root->firstChild() == nullptr case is handle by L389.

[Inactive, 2014-08-20 15:12:17]

Thanks. Levi, can you please give OWNER review?

[leviw_travelin_and_unemployed, 2014-08-20 18:24:18]

The CQ bit was checked by leviw@chromium.org

[leviw_travelin_and_unemployed, 2014-08-20 18:24:18]

lgtm

[commit-bot: I haz the power, 2014-08-20 18:24:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/485313002/1

[commit-bot: I haz the power, 2014-08-20 18:29:13]

Committed patchset #1 (1) as 180673