Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: test/base-unittests/testcfg.py

Issue 485273004: Fix parsing of --gtest_list_tests output. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/compiler-unittests/testcfg.py » ('j') | test/compiler-unittests/testcfg.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/base-unittests/testcfg.py
diff --git a/test/base-unittests/testcfg.py b/test/base-unittests/testcfg.py
index 0ed46dcdb117b5060fae8e8502cf6b18de525002..8791793c0a88d55caa3f7c22f5f091a7a2099589 100644
--- a/test/base-unittests/testcfg.py
+++ b/test/base-unittests/testcfg.py
@@ -28,10 +28,11 @@ class BaseUnitTestsSuite(testsuite.TestSuite):
return []
tests = []
test_case = ''
- for test_desc in output.stdout.strip().split():
+ for line in output.stdout.splitlines():
+ test_desc = line.strip().split()[0]
if test_desc.endswith('.'):
test_case = test_desc
- else:
+ elif test_case:
Michael Achenbach 2014/08/21 12:34:15 How about: elif test_case and test_desc: Otherwi
Benedikt Meurer 2014/08/21 12:35:46 Done.
test = testcase.TestCase(self, test_case + test_desc, dependency=None)
tests.append(test)
tests.sort()
« no previous file with comments | « no previous file | test/compiler-unittests/testcfg.py » ('j') | test/compiler-unittests/testcfg.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698