Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 485273004: Fix parsing of --gtest_list_tests output. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix parsing of --gtest_list_tests output. R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23273

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M test/base-unittests/testcfg.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M test/compiler-unittests/testcfg.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M test/heap-unittests/testcfg.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M test/runtime-unittests/testcfg.py View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
6 years, 4 months ago (2014-08-21 12:29:54 UTC) #1
Michael Achenbach
LGTM with comments: https://codereview.chromium.org/485273004/diff/1/test/base-unittests/testcfg.py File test/base-unittests/testcfg.py (right): https://codereview.chromium.org/485273004/diff/1/test/base-unittests/testcfg.py#newcode35 test/base-unittests/testcfg.py:35: elif test_case: How about: elif test_case ...
6 years, 4 months ago (2014-08-21 12:34:16 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/485273004/diff/1/test/base-unittests/testcfg.py File test/base-unittests/testcfg.py (right): https://codereview.chromium.org/485273004/diff/1/test/base-unittests/testcfg.py#newcode35 test/base-unittests/testcfg.py:35: elif test_case: On 2014/08/21 12:34:15, Michael Achenbach wrote: > ...
6 years, 4 months ago (2014-08-21 12:35:47 UTC) #3
Benedikt Meurer
6 years, 4 months ago (2014-08-21 12:36:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as 23273 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698