Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2016)

Unified Diff: Tools/GardeningServer/model/ct-commit.html

Issue 485253004: [Sheriff-o-matic] Remove race condition on the commit list. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: names Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/GardeningServer/model/ct-commit-list.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/model/ct-commit.html
diff --git a/Tools/GardeningServer/model/ct-commit.html b/Tools/GardeningServer/model/ct-commit.html
index 08a56c4990d2a0aea09723dcf2ecc933a68cb886..92214d6d84f2f229862bb3cc4415744f1655aecc 100644
--- a/Tools/GardeningServer/model/ct-commit.html
+++ b/Tools/GardeningServer/model/ct-commit.html
@@ -9,10 +9,8 @@ function CTCommit() {}
CTCommit.create = function(author, message, baseUrl, repository) {
var commit = new CTCommit();
- commit.author = author;
- commit.message = message;
- commit.revision = commit._findRevision();
- commit.summary = commit._findSummary();
+ var revision = CTCommit.findRevision(message);
+ commit.complete(author, message, revision);
commit.url = commit._url(baseUrl);
commit.repository = repository;
return commit;
@@ -28,20 +26,28 @@ CTCommit.createIncomplete = function(baseUrl, revision, repository) {
return commit;
}
-CTCommit.prototype._url = function(baseUrl) {
- return baseUrl.assign({revision: this.revision});
-}
-
-CTCommit.prototype._findRevision = function() {
+CTCommit.findRevision = function(message) {
// FIXME: This needs to be updated post git-migration to
// use the new commit numbers (ideally not git hashes!).
var regexp = /git-svn-id:[^@]*@(\d+)/;
- var match = regexp.exec(this.message);
+ var match = regexp.exec(message);
if (match)
return parseInt(match[1], 10);
return null;
}
+CTCommit.prototype.complete = function(author, message, revision) {
+ this.author = author;
+ this.message = message;
+ this.revision = revision;
+ this.summary = this._findSummary();
+ this.isComplete = true;
+}
+
+CTCommit.prototype._url = function(baseUrl) {
+ return baseUrl.assign({revision: this.revision});
+}
+
CTCommit.prototype._findSummary = function() {
var index = this.message.indexOf('\n');
return this.message.substring(0, index);
« no previous file with comments | « no previous file | Tools/GardeningServer/model/ct-commit-list.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698