Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2149)

Unified Diff: Tools/GardeningServer/model/ct-commit.html

Issue 485253004: [Sheriff-o-matic] Remove race condition on the commit list. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/model/ct-commit.html
diff --git a/Tools/GardeningServer/model/ct-commit.html b/Tools/GardeningServer/model/ct-commit.html
index 08a56c4990d2a0aea09723dcf2ecc933a68cb886..937898628321ac53453d09928a4644c111136f82 100644
--- a/Tools/GardeningServer/model/ct-commit.html
+++ b/Tools/GardeningServer/model/ct-commit.html
@@ -9,10 +9,7 @@ function CTCommit() {}
CTCommit.create = function(author, message, baseUrl, repository) {
var commit = new CTCommit();
- commit.author = author;
- commit.message = message;
- commit.revision = commit._findRevision();
- commit.summary = commit._findSummary();
+ commit.complete(author, message);
commit.url = commit._url(baseUrl);
commit.repository = repository;
return commit;
@@ -28,6 +25,14 @@ CTCommit.createIncomplete = function(baseUrl, revision, repository) {
return commit;
}
+CTCommit.prototype.complete = function(author, message) {
+ this.author = author;
+ this.message = message;
+ this.revision = this._findRevision();
+ this.summary = this._findSummary();
+ this.isComplete = true;
+}
+
CTCommit.prototype._url = function(baseUrl) {
return baseUrl.assign({revision: this.revision});
}
« no previous file with comments | « no previous file | Tools/GardeningServer/model/ct-commit-list.html » ('j') | Tools/GardeningServer/model/ct-commit-log.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698