[Sheriff-o-matic] Remove race condition on the commit list.

Tools/GardeningServer/ui/ct-unexpected-failures.html

 <!--
 Copyright 2014 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
 <link rel="import" href="../bower_components/paper-button/paper-button.html">
 <link rel="import" href="../lib/ct-scheduled-updater.html">
 <link rel="import" href="../model/ct-commit-log.html">
 <link rel="import" href="../model/tree-status.html">
@@ skipping 22 matching lines @@
 
       .toolbar {
         display: flex;
         justify-content: space-between;
         align-items: baseline;
         padding: 0 5px;
       }
     </style>
     <ct-failure-analyzer id="analyzer" failures="{{ failures }}" builderLatestRevisions="{{ builderLatestRevisions }}" lastUpdateDate="{{ lastUpdateDate }}"></ct-failure-analyzer>
     <div class="toolbar">
-      <ct-revision-details id="revisionDetails" builderLatestRevisions="{{ builderLatestRevisions }}" revisionLog="{{ revisionLog }}" tree="{{ tree }}"></ct-revision-details>
+      <ct-revision-details id="revisionDetails" builderLatestRevisions="{{ builderLatestRevisions }}" commitLog="{{ commitLog }}" tree="{{ tree }}"></ct-revision-details>
       <a href="https://code.google.com/p/chromium/wiki/UsefulURLs">Useful URLs</a>
     </div>
     <ct-tree-status status="{{ treeStatuses['chromium'] }}" state="{{ treeStatuses['chromium'].status }}"></ct-tree-status>
     <ct-tree-status status="{{ treeStatuses['blink'] }}" state="{{ treeStatuses['blink'].status }}"></ct-tree-status>
     <ct-party-time failures="{{ failures }}" tree="{{ tree }}"></ct-party-time>
-    <ct-failure-stream category="default" groups="{{ failures[tree] }}" commits="{{ revisionLog }}" tree="{{ tree }}"></ct-failure-stream>
-    <ct-failure-stream category="snoozed" groups="{{ failures[tree] }}" commits="{{ revisionLog }}" tree="{{ tree }}"></ct-failure-stream>
+    <ct-failure-stream category="default" groups="{{ failures[tree] }}" commitLog="{{ commitLog }}" tree="{{ tree }}"></ct-failure-stream>
+    <ct-failure-stream category="snoozed" groups="{{ failures[tree] }}" commitLog="{{ commitLog }}" tree="{{ tree }}"></ct-failure-stream>
   </template>
   <script>
   (function() {
     var kUpdateFrequency = 1000 * 30;
 
     Polymer({
       tree: '',
 
       created: function() {
-        this.revisionLog = new CTCommitLog(),
+        window.console.log('created CTCommitLog');

[ojan, 2014/08/20 18:47:51]

Leftover debugging code?

[Mathieu, 2014/08/21 14:08:21]

Done.

+        this.commitLog = new CTCommitLog(),
         this._updater = new CTScheduledUpdater(this.update.bind(this), kUpdateFrequency);
 
         this.treeStatuses = {};
         var projects = ['chromium', 'blink'];
         for (var i = 0; i < projects.length; i++) {
           this.treeStatuses[projects[i]] = new TreeStatus(projects[i]);
         }
       },
 
       attached: function() {
         this.update();
       },
 
       update: function() {
+        window.console.log('unexpected-failures: update');

[ojan, 2014/08/20 18:47:51]

Ditto

[Mathieu, 2014/08/21 14:08:21]

Oops! Proof I'm human!

         // FIXME: These shouldn't update if there's already an update in progress.
-        this.revisionLog.update();
+        this.commitLog.update();
         this.$.analyzer.update();
         Object.keys(this.treeStatuses, function(tree, status) {
           status.update();
         });
       },
     });
   })();
   </script>
 </polymer-element>