[Sheriff-o-matic] Remove race condition on the commit list.

Tools/GardeningServer/ui/ct-failure-card.html

 <!--
 Copyright 2014 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
 <link rel="import" href="ct-builder-grid.html">
 <link rel="import" href="ct-commit-list.html">
 <link rel="import" href="ct-test-list.html">
 <link rel="import" href="../bower_components/paper-dialog/paper-dialog.html">
 <link rel="import" href="../bower_components/paper-dialog/paper-dialog-transition.html">
 <link rel="import" href="../bower_components/paper-input/paper-input.html">
 
-<polymer-element name="ct-failure-card" attributes="group commits tree bug">
+<polymer-element name="ct-failure-card" attributes="group commitLog tree bug">
   <template>
     <style>
       :host {
         display: flex;
       }
 
       /* FIXME: All this paper-button styling should go in a cr-button component so that
          we can use buttons in different places and have them all look the same. */
       paper-button {
         -webkit-user-select: none;
@@ skipping 64 matching lines @@
 
     <paper-dialog heading="Enter bug number" transition="paper-transition-center" id="bugDialog">
       <paper-input label="Bug# or URL" floatingLabel autofocus id="bug"></paper-input>
       <paper-button label="Remove bug link" on-tap="{{ removeBug }}" dismissive id="dialogRemoveBug"></paper-button>
       <paper-button label="OK" on-tap="{{ saveBug }}" affirmative id="dialogOk"></paper-button>
     </paper-dialog>
   </template>
   <script>
     Polymer({
       group: null,
-      commits: null,
+      commitLog: null,
       tree: '',
 
       examine: function() {
         this.fire('ct-examine-failures', this.group);
       },
 
       snooze: function() {
         this.group.snoozeUntil(Date.now() + 60 * 60 * 1000);
       },
 
       unsnooze: function() {
         this.group.unsnooze();
       },
 
       _commits: function() {
         if (!this.group)
           return undefined;
-        return this.group.commitList(this.commits);
+        return this.group.commitList(this.commitLog);

[ojan, 2014/08/20 18:47:51]

Can you add a test that would have broken in the old code?

Particularly, create a ct-failure-card with an unpopulated commitLog. setTimout.
Assert that it has commits without descriptions. Then populate the commitLog.
setTimeout. Assert that it has commits *with* descriptions.

[Mathieu, 2014/08/21 14:08:21]

Done.

       },
 
       linkBug: function() {
         this.$.bug.value = this.group.bug;
         this.$.bugDialog.toggle();
       },
 
       saveBug: function() {
         this.group.setBug(this.$.bug.value);
       },
 
       removeBug: function() {
         this.group.clearBug();
       },
     });
   </script>
 </polymer-element>