Issue 485243002: Fix few minor easy unlock bugs

Issue 485243002: Fix few minor easy unlock bugs (Closed)

Created:
6 years, 4 months ago by tbarzic

Modified:
6 years, 4 months ago

Reviewers:
xiyuan, Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix few minor easy unlock bugs This fixes: Tooltip for NO_BLUETOOTH state has '$1' instead of Chromebook Adds PHONE_UNSUPPORTED state Clears screenlock state when Easy Unlock gets turned off BUG=403831, 404775 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290681

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 4

Patch Set 4 : #

Total comments: 2

Patch Set 5 : . #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -3 lines)			Patch
M	chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/signin/easy_unlock_screenlock_state_handler.h	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/signin/easy_unlock_screenlock_state_handler.cc	View		4 chunks	+13 lines, -2 lines	0 comments	Download
M	chrome/browser/signin/easy_unlock_service.cc	View	1 2 3	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/common/extensions/api/easy_unlock_private.idl	View	1 2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

xiyuan

LGTM https://codereview.chromium.org/485243002/diff/40001/chrome/browser/signin/easy_unlock_screenlock_state_handler.h File chrome/browser/signin/easy_unlock_screenlock_state_handler.h (right): https://codereview.chromium.org/485243002/diff/40001/chrome/browser/signin/easy_unlock_screenlock_state_handler.h#newcode42 chrome/browser/signin/easy_unlock_screenlock_state_handler.h:42: // the device because it does not support ...

6 years, 4 months ago (2014-08-19 20:17:13 UTC) #2

tbarzic

https://codereview.chromium.org/485243002/diff/40001/chrome/browser/signin/easy_unlock_screenlock_state_handler.h File chrome/browser/signin/easy_unlock_screenlock_state_handler.h (right): https://codereview.chromium.org/485243002/diff/40001/chrome/browser/signin/easy_unlock_screenlock_state_handler.h#newcode42 chrome/browser/signin/easy_unlock_screenlock_state_handler.h:42: // the device because it does not support reporting ...

6 years, 4 months ago (2014-08-19 20:24:59 UTC) #3

Yoyo Zhou

LGTM, but https://codereview.chromium.org/485243002/diff/50001/chrome/common/extensions/api/easy_unlock_private.idl File chrome/common/extensions/api/easy_unlock_private.idl (right): https://codereview.chromium.org/485243002/diff/50001/chrome/common/extensions/api/easy_unlock_private.idl#newcode43 chrome/common/extensions/api/easy_unlock_private.idl:43: // Easy Unlock enabled phone is detected, ...

6 years, 4 months ago (2014-08-19 21:03:24 UTC) #5

tbarzic

https://codereview.chromium.org/485243002/diff/50001/chrome/common/extensions/api/easy_unlock_private.idl File chrome/common/extensions/api/easy_unlock_private.idl (right): https://codereview.chromium.org/485243002/diff/50001/chrome/common/extensions/api/easy_unlock_private.idl#newcode43 chrome/common/extensions/api/easy_unlock_private.idl:43: // Easy Unlock enabled phone is detected, but it ...

6 years, 4 months ago (2014-08-19 21:06:38 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/485243002/70001

6 years, 4 months ago (2014-08-19 21:07:53 UTC) #8

commit-bot: I haz the power

6 years, 4 months ago (2014-08-19 22:41:58 UTC) #9

Message was sent while issue was closed.

Committed patchset #5 (70001) as 290681

Expand Messages | Collapse Messages