Issue 48523009: Fix unused functions warnings on Linux.

Issue 48523009: Fix unused functions warnings on Linux. (Closed)

Created:
7 years, 1 month ago by lgombos

Modified:
7 years, 1 month ago

Reviewers:
Nico, abarth-chromium

CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, Nils Barth (inactive), jamesr, Nate Chapin, aboxhall, bemjb+rendering_chromium.org, dsinclair, yurys+blink_chromium.org, abarth-chromium, danakj, marja+watch_chromium.org, dglazkov+blink, Rik, gavinp+loader_chromium.org, jchaffraix+rendering, pdr., loislo+blink_chromium.org, zoltan1, dmazzoni, darktears, haraken, kojih, jsbell+bindings_chromium.org, leviw+renderwatch, f(malita), Inactive, Stephen Chennney

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Fix unused functions warnings on Linux. BUG=312287 TBR=abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160945

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comments #

Total comments: 1

Patch Set 3 : Fix DragController #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -137 lines)			Patch
M	Source/bindings/v8/ScriptController.cpp	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	Source/core/accessibility/AXObject.cpp	View		2 chunks	+0 lines, -72 lines	0 comments	Download
M	Source/core/css/CSSParser-in.cpp	View		1 chunk	+0 lines, -11 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	1	1 chunk	+0 lines, -11 lines	0 comments	Download
M	Source/core/html/HTMLAnchorElement.cpp	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	Source/core/loader/FrameLoader.cpp	View	1	1 chunk	+0 lines, -11 lines	0 comments	Download
M	Source/core/page/DragController.cpp	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/core/platform/graphics/AlternateFontFamily.h	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/rendering/RenderEmbeddedObject.cpp	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	Source/weborigin/SecurityOriginTest.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

lgombos

..almost there to enable -Wall on Linux as well with this..

7 years, 1 month ago (2013-10-29 22:59:58 UTC) #1

Nico

lgtm, but I'd revert the change to WTFTestHelpers.h I think (but up to you) Thanks! ...

7 years, 1 month ago (2013-10-29 23:07:43 UTC) #2

lgombos

abarth@chromium.org: Please review changes in weborigin/ and bindings/. Thanks. https://codereview.chromium.org/48523009/diff/1/Source/core/loader/FrameLoader.cpp File Source/core/loader/FrameLoader.cpp (right): https://codereview.chromium.org/48523009/diff/1/Source/core/loader/FrameLoader.cpp#newcode110 Source/core/loader/FrameLoader.cpp:110: ...

7 years, 1 month ago (2013-10-30 03:37:55 UTC) #3

Nico

I think this is a small enough change to weborigin/ and bindings/ that it can ...

7 years, 1 month ago (2013-10-30 03:39:47 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/48523009/100001

7 years, 1 month ago (2013-10-30 03:40:10 UTC) #5

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 1 month ago (2013-10-30 04:03:55 UTC) #6

Nico

https://codereview.chromium.org/48523009/diff/100001/Source/core/page/DragController.cpp File Source/core/page/DragController.cpp (left): https://codereview.chromium.org/48523009/diff/100001/Source/core/page/DragController.cpp#oldcode95 Source/core/page/DragController.cpp:95: static bool dragTypeIsValid(DragSourceAction action) This apparently needs to be ...

7 years, 1 month ago (2013-10-30 04:24:20 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/48523009/260001

7 years, 1 month ago (2013-10-30 14:34:13 UTC) #8

Message was sent while issue was closed.

Change committed as 160945

Expand Messages | Collapse Messages