Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: include/core/SkPaint.h

Issue 48523008: All SkAnnotations are no-draw. Propose we fold that through. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: deprecate Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/core/SkAnnotation.h ('k') | src/core/SkAnnotation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkPaint.h
diff --git a/include/core/SkPaint.h b/include/core/SkPaint.h
index 52321ddaf6c8738a83d69e156d4fb7cd70e98271..6c3a10f9efe3bdb05a3c9b8189e3c85b0015bb50 100644
--- a/include/core/SkPaint.h
+++ b/include/core/SkPaint.h
@@ -638,10 +638,10 @@ public:
/**
* Returns true if there is an annotation installed on this paint, and
* the annotation specifics no-drawing.
+ *
+ * Deprecated: all annotations are no-draw. Please just check getAnnotation().
*/
- bool isNoDrawAnnotation() const {
- return SkToBool(fPrivFlags & kNoDrawAnnotation_PrivFlag);
- }
+ bool isNoDrawAnnotation() const { return this->getAnnotation() != NULL; }
/**
* Return the paint's SkDrawLooper (if any). Does not affect the looper's
@@ -1006,11 +1006,8 @@ private:
unsigned fStyle : 2;
unsigned fTextEncoding : 2; // 3 values
unsigned fHinting : 2;
- unsigned fPrivFlags : 4; // these are not flattened/unflattened
+ //unsigned fFreeBits : 4;
- enum PrivFlags {
- kNoDrawAnnotation_PrivFlag = 1 << 0,
- };
SkDrawCacheProc getDrawCacheProc() const;
SkMeasureCacheProc getMeasureCacheProc(TextBufferDirection dir,
« no previous file with comments | « include/core/SkAnnotation.h ('k') | src/core/SkAnnotation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698