All SkAnnotations are no-draw. Propose we fold that through.

All SkAnnotations are no-draw.  Propose we fold that through.

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=12008

[edisonn, 2013-10-29 19:44:36]

LGTM - have you run it with the gm? check diff with pdfs please.

https://codereview.chromium.org/48523008/diff/1/include/core/SkPaint.h
File include/core/SkPaint.h (right):

https://codereview.chromium.org/48523008/diff/1/include/core/SkPaint.h#newcod...
include/core/SkPaint.h:640: *  the annotation specifics no-drawing.
update comment

[reed1, 2013-10-29 19:48:49]

lgtm w/ comment comment

https://codereview.chromium.org/48523008/diff/1/include/core/SkPaint.h
File include/core/SkPaint.h (right):

https://codereview.chromium.org/48523008/diff/1/include/core/SkPaint.h#newcod...
include/core/SkPaint.h:640: *  the annotation specifics no-drawing.
On 2013/10/29 19:44:36, edisonn wrote:
> update comment

Perhaps mark as DEPRECATED, since getAnnotation already exists.

[mtklein, 2013-10-29 20:28:52]

Re: GM, I'm going to try to boldly roll forward with this one.  The only place
SkAnnotation's constructor is called today always forces no-draw.  (I changed
the constructor interface and only had to change that call.)  This makes me
confident that there's no way we can be changing behavior.  I'll keep an eye on
the GMs.

https://codereview.chromium.org/48523008/diff/1/include/core/SkPaint.h
File include/core/SkPaint.h (right):

https://codereview.chromium.org/48523008/diff/1/include/core/SkPaint.h#newcod...
include/core/SkPaint.h:640: *  the annotation specifics no-drawing.
On 2013/10/29 19:48:49, reed1 wrote:
> On 2013/10/29 19:44:36, edisonn wrote:
> > update comment
> 
> Perhaps mark as DEPRECATED, since getAnnotation already exists.

Done.

[commit-bot: I haz the power, 2013-10-29 20:30:16]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@google.com/48523008/50001

[commit-bot: I haz the power, 2013-10-29 20:44:42]

Change committed as 12008