Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: tools/gn/value_extractors.h

Issue 48523006: GN: Separately track labels and origins for lists of stuff (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/target_unittest.cc ('k') | tools/gn/value_extractors.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/value_extractors.h
diff --git a/tools/gn/value_extractors.h b/tools/gn/value_extractors.h
index 12fff00795dac926631bc0b00f1034448dd8db54..ff1611d6b9cab75bb6ecaa791f1a018d520dc1d9 100644
--- a/tools/gn/value_extractors.h
+++ b/tools/gn/value_extractors.h
@@ -8,6 +8,7 @@
#include <string>
#include <vector>
+#include "tools/gn/target.h"
#include "tools/gn/value.h"
class BuildSettings;
@@ -51,10 +52,17 @@ bool ExtractListOfRelativeDirs(const BuildSettings* build_settings,
std::vector<SourceDir>* dest,
Err* err);
+// Extracts the list of labels and their origins to the given vector. Only the
+// labels are filled in, the ptr for each pair in the vector will be null.
bool ExtractListOfLabels(const Value& value,
const SourceDir& current_dir,
const Label& current_toolchain,
- std::vector<Label>* dest,
+ LabelConfigVector* dest,
+ Err* err);
+bool ExtractListOfLabels(const Value& value,
+ const SourceDir& current_dir,
+ const Label& current_toolchain,
+ LabelTargetVector* dest,
Err* err);
#endif // TOOLS_GN_VALUE_EXTRACTORS_H_
« no previous file with comments | « tools/gn/target_unittest.cc ('k') | tools/gn/value_extractors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698