Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: tools/gn/ninja_target_writer.cc

Issue 48523006: GN: Separately track labels and origins for lists of stuff (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_group_target_writer.cc ('k') | tools/gn/target.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_target_writer.cc
diff --git a/tools/gn/ninja_target_writer.cc b/tools/gn/ninja_target_writer.cc
index a7bd6cc32e454d2bb75f0de1dea5b6757a42411d..d73c873271d0784a252be41dea5e7b866b6ff663 100644
--- a/tools/gn/ninja_target_writer.cc
+++ b/tools/gn/ninja_target_writer.cc
@@ -102,12 +102,12 @@ std::string NinjaTargetWriter::GetSourcesImplicitDeps() const {
}
// Add on any direct deps marked as "hard".
- const std::vector<const Target*>& deps = target_->deps();
+ const LabelTargetVector& deps = target_->deps();
for (size_t i = 0; i < deps.size(); i++) {
- if (deps[i]->hard_dep()) {
+ if (deps[i].ptr->hard_dep()) {
has_files = true;
ret << " ";
- path_output_.WriteFile(ret, helper_.GetTargetOutputFile(deps[i]));
+ path_output_.WriteFile(ret, helper_.GetTargetOutputFile(deps[i].ptr));
}
}
« no previous file with comments | « tools/gn/ninja_group_target_writer.cc ('k') | tools/gn/target.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698