Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: tools/gn/ninja_group_target_writer.cc

Issue 48523006: GN: Separately track labels and origins for lists of stuff (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_binary_target_writer_unittest.cc ('k') | tools/gn/ninja_target_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_group_target_writer.cc
diff --git a/tools/gn/ninja_group_target_writer.cc b/tools/gn/ninja_group_target_writer.cc
index df95a82dcfdfdf9bab0bfa6c216f90549d73d68e..606f916c7d3536efcc03a4526935cf27ebb971c6 100644
--- a/tools/gn/ninja_group_target_writer.cc
+++ b/tools/gn/ninja_group_target_writer.cc
@@ -24,16 +24,16 @@ void NinjaGroupTargetWriter::Run() {
<< helper_.GetRulePrefix(target_->settings()->toolchain())
<< "stamp";
- const std::vector<const Target*>& deps = target_->deps();
+ const LabelTargetVector& deps = target_->deps();
for (size_t i = 0; i < deps.size(); i++) {
out_ << " ";
- path_output_.WriteFile(out_, helper_.GetTargetOutputFile(deps[i]));
+ path_output_.WriteFile(out_, helper_.GetTargetOutputFile(deps[i].ptr));
}
- const std::vector<const Target*>& datadeps = target_->datadeps();
+ const LabelTargetVector& datadeps = target_->datadeps();
for (size_t i = 0; i < datadeps.size(); i++) {
out_ << " ";
- path_output_.WriteFile(out_, helper_.GetTargetOutputFile(datadeps[i]));
+ path_output_.WriteFile(out_, helper_.GetTargetOutputFile(datadeps[i].ptr));
}
out_ << std::endl;
}
« no previous file with comments | « tools/gn/ninja_binary_target_writer_unittest.cc ('k') | tools/gn/ninja_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698