Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: tools/gn/command_gyp.cc

Issue 48523006: GN: Separately track labels and origins for lists of stuff (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/command_desc.cc ('k') | tools/gn/config_values_extractors.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_gyp.cc
diff --git a/tools/gn/command_gyp.cc b/tools/gn/command_gyp.cc
index de089d393cfbf7a60ea49a678c56d318a035ae69..81dc2226a753debc640368137ea94a06ed4f45a3 100644
--- a/tools/gn/command_gyp.cc
+++ b/tools/gn/command_gyp.cc
@@ -96,11 +96,11 @@ bool EnsureTargetsMatch(const TargetGroup& group, Err* err) {
return false;
}
for (size_t i = 0; i < group.debug->deps().size(); i++) {
- if (group.debug->deps()[i]->label() != group.release->deps()[i]->label()) {
+ if (group.debug->deps()[i].label != group.release->deps()[i].label) {
*err = Err(Location(), "The debug and release version of the target \n" +
group.debug->label().GetUserVisibleName(true) +
"\ndon't agree on the dep\n" +
- group.debug->deps()[i]->label().GetUserVisibleName(true));
+ group.debug->deps()[i].label.GetUserVisibleName(true));
return false;
}
}
« no previous file with comments | « tools/gn/command_desc.cc ('k') | tools/gn/config_values_extractors.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698