introduced athena_main_lib

introduced athena_main_lib

separate the process to initialize environment, and
start the session.

These are necessary step to launch athena in chrome.

BUG=397167
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290686

[Jun Mukai, 2014-08-19 17:22:35]

https://codereview.chromium.org/485183002/diff/40001/athena/main/athena_launc...
File athena/main/athena_launcher.cc (right):

https://codereview.chromium.org/485183002/diff/40001/athena/main/athena_launc...
athena/main/athena_launcher.cc:60: // TODO(oshima): move the VK bounds logic to
screen manager.
Note that VK depends on content layer (because VK is a webui), which makes
harder to add logic to screen manager.

https://codereview.chromium.org/485183002/diff/40001/athena/main/athena_launc...
athena/main/athena_launcher.cc:142: void
StartAthenaSession(athena::ActivityFactory* activity_factory,
Do we need to keep this?
athena_unittests now depends on content layer, so initialization with
TestBrowserContext would be acceptable.

https://codereview.chromium.org/485183002/diff/40001/athena/main/athena_main.gyp
File athena/main/athena_main.gyp (left):

https://codereview.chromium.org/485183002/diff/40001/athena/main/athena_main....
athena/main/athena_main.gyp:60: 'target_name': 'athena_shell',
just to confirm; do you intentionally remove athena_shell and silently add
dependency to content from athena_unittests right?
It would be great to send a PSA to the team when submitting this CL.

[oshima, 2014-08-19 18:05:49]

https://codereview.chromium.org/485183002/diff/40001/athena/main/athena_launc...
File athena/main/athena_launcher.cc (right):

https://codereview.chromium.org/485183002/diff/40001/athena/main/athena_launc...
athena/main/athena_launcher.cc:60: // TODO(oshima): move the VK bounds logic to
screen manager.
On 2014/08/19 17:22:35, Jun Mukai wrote:
> Note that VK depends on content layer (because VK is a webui), which makes
> harder to add logic to screen manager.

What I meant is to move the observer interface to screen instead.
If this is only place that needs take an action, we may leave it as is.

https://codereview.chromium.org/485183002/diff/40001/athena/main/athena_launc...
athena/main/athena_launcher.cc:142: void
StartAthenaSession(athena::ActivityFactory* activity_factory,
On 2014/08/19 17:22:35, Jun Mukai wrote:
> Do we need to keep this?
> athena_unittests now depends on content layer, so initialization with
> TestBrowserContext would be acceptable.

That's not enough because test doesn't initialize shell extension.
We'll remove it, but not ready yet.

https://codereview.chromium.org/485183002/diff/40001/athena/main/athena_main.gyp
File athena/main/athena_main.gyp (left):

https://codereview.chromium.org/485183002/diff/40001/athena/main/athena_main....
athena/main/athena_main.gyp:60: 'target_name': 'athena_shell',
On 2014/08/19 17:22:35, Jun Mukai wrote:
> just to confirm; do you intentionally remove athena_shell and

We discussed this in the meeting. I'll send out PSA.

> silently add
> dependency to content from athena_unittests right?
> It would be great to send a PSA to the team when submitting this CL.

content dependency isn't new. see athena_test_support.

I actually forgot to do gyp cleanup. I removed unnecessary deps.
PTAL.

[Jun Mukai, 2014-08-19 21:23:50]

lgtm

[oshima, 2014-08-19 21:30:39]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-08-19 21:32:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/485183002/100001

[commit-bot: I haz the power, 2014-08-19 22:53:14]

Committed patchset #2 (100001) as 290686