Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 485103007: Revert of Pass decoded picture size from VDA to client (Closed)

Created:
6 years, 4 months ago by jennyz
Modified:
6 years, 4 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, wjia+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Pass decoded picture size from VDA to client (patchset #18 of https://codereview.chromium.org/426873004/) Reason for revert: This cl broke the daisy (chromium) build. http://build.chromium.org/p/chromiumos.chromium/builders/Daisy%20%28chromium%29/builds/1256 Original issue's description: > Pass decoded picture size from VDA to client > > Some of the VDAs, like DXVA and AVDA, don't distinguish > between visible size and coded size. And given GVD is always > been used with container, we should keep using size from > config in GVD. > > BUG=390048 > TEST=Manually tested: flash player using youtube. html5 > player with resolution 1280x720 and 1216x684, h264 and vp8. > apprtc with resolution 640x480 and 636x476. All tests are > performed on both daisy and link. > R=hshi@chromium.org, posciak@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291187

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -100 lines) Patch
M content/common/gpu/client/gpu_video_decode_accelerator_host.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/common/gpu/client/gpu_video_decode_accelerator_host.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 chunk +3 lines, -4 lines 0 comments Download
M content/common/gpu/media/android_video_decode_accelerator.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/common/gpu/media/dxva_video_decode_accelerator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/common/gpu/media/v4l2_video_decode_accelerator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/common/gpu/media/vt_video_decode_accelerator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/rtc_video_decoder.h View 3 chunks +13 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_video_decoder.cc View 6 chunks +23 lines, -21 lines 0 comments Download
M content/renderer/pepper/pepper_video_decoder_host.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/pepper/ppb_video_decoder_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/pepper/video_decoder_shim.cc View 6 chunks +10 lines, -17 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M media/video/picture.h View 3 chunks +1 line, -10 lines 0 comments Download
M media/video/picture.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jennyz
Created Revert of Pass decoded picture size from VDA to client
6 years, 4 months ago (2014-08-21 23:01:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/485103007/1
6 years, 4 months ago (2014-08-21 23:03:34 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 23:03:34 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-21 23:03:35 UTC) #4
hshi1
lgtm
6 years, 4 months ago (2014-08-21 23:05:29 UTC) #5
jennyz
The CQ bit was checked by jennyz@chromium.org
6 years, 4 months ago (2014-08-21 23:07:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/485103007/1
6 years, 4 months ago (2014-08-21 23:09:39 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 00:21:56 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 00:25:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8276)
6 years, 4 months ago (2014-08-22 00:25:05 UTC) #10
Owen Lin
On 2014/08/22 00:25:05, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 4 months ago (2014-08-22 03:30:55 UTC) #11
hshi1
6 years, 4 months ago (2014-08-22 21:17:24 UTC) #12
On 2014/08/22 03:30:55, Owen Lin wrote:
> On 2014/08/22 00:25:05, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   android_chromium_gn_compile_rel on tryserver.chromium.linux
> >
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
> 
> I am going to submit a fix for it. Please don't submit this revert. Thanks.
> 
> https://codereview.chromium.org/483093005/

Thanks Owen for fixing the ARM build. I think it is safe to mark this issue as
closed.

Powered by Google App Engine
This is Rietveld 408576698