Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 485103006: Mac Video Capture: correct float framerate wrongly casted to int (Closed)

Created:
6 years, 4 months ago by mcasas
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mac Video Capture: correct float framerate wrongly casted to int This migration int -> float was still missing. BUG=380463, 394315 Committed: https://crrev.com/3831141691e27d79130bc784e55e7ff34a75b099 Cr-Commit-Position: refs/heads/master@{#292881}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/video/capture/mac/video_capture_device_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (1 generated)
mcasas
tommi@ tiny review PTAL.
6 years, 4 months ago (2014-08-21 15:07:49 UTC) #1
tommi (sloooow) - chröme
lgtm. interesting - were there no warnings for this? (this should normally break compilation but ...
6 years, 4 months ago (2014-08-21 17:59:59 UTC) #2
tommi (sloooow) - chröme
The CQ bit was checked by tommi@chromium.org
6 years, 4 months ago (2014-08-21 18:00:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/485103006/1
6 years, 4 months ago (2014-08-21 18:01:44 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-21 21:47:53 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 22:12:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8179)
6 years, 4 months ago (2014-08-21 22:12:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/485103006/1
6 years, 3 months ago (2014-09-01 16:16:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3a8f25962de211ad690e093272e745a54f60e178
6 years, 3 months ago (2014-09-01 16:39:51 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:17:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3831141691e27d79130bc784e55e7ff34a75b099
Cr-Commit-Position: refs/heads/master@{#292881}

Powered by Google App Engine
This is Rietveld 408576698