Issue 485093003: Make it obvious an HTMLOptionsCollection can only contain HTMLOptionElements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 485093003: Make it obvious an HTMLOptionsCollection can only contain HTMLOptionElements (Closed)

Created:
6 years, 4 months ago by Inactive

Modified:
6 years, 4 months ago

Reviewers:
adamk

CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Make it obvious an HTMLOptionsCollection can only contain HTMLOptionElements Make it obvious an HTMLOptionsCollection can only contain HTMLOptionElements by using tighter typing. This CL also moves the Element matching code from HTMLCollection to the HTMLOptionsCollection subclass for consistency with other HTMLCollection subclasses. R=adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180676

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -8 lines)			Patch
M	Source/core/html/HTMLCollection.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLOptionsCollection.h	View	3 chunks	+10 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLSelectElement.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLSelectElement.cpp	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/485093003/1

6 years, 4 months ago (2014-08-20 18:45:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 180676

Expand Messages | Collapse Messages