pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart - Issue 485083004: Make RefactoringStatus a collection of generated RefactoringProblems.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart

Issue 485083004: Make RefactoringStatus a collection of generated RefactoringProblems. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/lib/src/services/correction/status.dart ('K') | « pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart ('k') | pkg/analysis_server/test/services/refactoring/rename_import_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart

diff --git a/pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart b/pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart

index 7cfd5f787528d7885fb94ca4a74b5c7d5f5f7e8c..a4f7fc0f7b59352c5d7243648bddefb914eb2e3d 100644

--- a/pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart

+++ b/pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart

@@ -4,7 +4,7 @@

library test.services.refactoring.rename_constructor;

-import 'package:analysis_server/src/services/correction/status.dart';

+import 'package:analysis_server/src/protocol2.dart';

import 'package:analysis_testing/reflective_tests.dart';

import 'package:analyzer/src/generated/ast.dart';

import 'package:analyzer/src/generated/element.dart';

@@ -34,7 +34,7 @@ class A {

return refactoring.checkFinalConditions().then((status) {

assertRefactoringStatus(

status,

- RefactoringStatusSeverity.ERROR,

+ RefactoringProblemSeverity.ERROR,

expectedMessage: "Class 'A' already declares constructor with name 'newName'.",

expectedContextSearch: 'newName() {} // existing');

});

@@ -53,7 +53,7 @@ class A {

return refactoring.checkFinalConditions().then((status) {

assertRefactoringStatus(

status,

- RefactoringStatusSeverity.ERROR,

+ RefactoringProblemSeverity.ERROR,

expectedMessage: "Class 'A' already declares method with name 'newName'.",

expectedContextSearch: 'newName() {} // existing');

});

@@ -71,13 +71,13 @@ class A {

refactoring.newName = null;

assertRefactoringStatus(

refactoring.checkNewName(),

- RefactoringStatusSeverity.ERROR,

+ RefactoringProblemSeverity.ERROR,

expectedMessage: "Constructor name must not be null.");

// same

refactoring.newName = 'test';

assertRefactoringStatus(

refactoring.checkNewName(),

- RefactoringStatusSeverity.FATAL,

+ RefactoringProblemSeverity.FATAL,

expectedMessage: "The new name must be different than the current name.");

// empty

refactoring.newName = '';