pkg/analysis_server/lib/src/services/refactoring/rename_local.dart - Issue 485083004: Make RefactoringStatus a collection of generated RefactoringProblems.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename_local.dart

Issue 485083004: Make RefactoringStatus a collection of generated RefactoringProblems. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/lib/src/services/correction/status.dart ('K') | « pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart ('k') | pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/rename_local.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename_local.dart b/pkg/analysis_server/lib/src/services/refactoring/rename_local.dart

index 9c1edf5020b8ea02ac68f4d8f29639a872ac3454..5a66747538e80efedffbdbd623c3959e7e4cd1ff 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/rename_local.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/rename_local.dart

@@ -121,7 +121,7 @@ class _ConflictValidatorVisitor extends RecursiveAstVisitor<Object> {

String message = "Duplicate ${nodeKind} '$newName'.";

result.addError(

message,

- new RefactoringStatusContext.forElement(nodeElement));

+ createLocation_forElement(nodeElement));

return null;

}

// shadowing referenced element

@@ -134,7 +134,7 @@ class _ConflictValidatorVisitor extends RecursiveAstVisitor<Object> {

String message =

'Usage of $nodeKind "$nodeName" declared in '

'"$nameElementSourceName" will be shadowed by renamed $refKind.';

- result.addError(message, new RefactoringStatusContext.forNode(node));

+ result.addError(message, createLocation_forNode(node));

}

return null;